When generating an cloned interface instance in edsc_clone_create(), generate a random MAC address

[nc]

Summary

When generating an cloned interface instance in edsc_clone_create(), generate a MAC address from the OUI with
ether_gen_addr(). This allows us to have unique local-link addresses. Previously, the MAC address was zero.

Submitted by: Neel Chauhan <neel AT neelc DOT org>

[nc]

I'm not sure if something else (meaning something more predictable) should be done instead of a random MAC. Should it?

[afedorov]

sys/net/if_edsc.c

154

I think this is incorrect. A multicast or something other incorrect address can be generated.
You may use ether_gen_addr(): http://bxr.su/FreeBSD/sys/net/if_ethersubr.c#1426
This function generate MAC from FreeBSD OUI.
For example, see how if_tuntap do it: http://bxr.su/FreeBSD/sys/net/if_tuntap.c#972

[nc]

Thanks for the advice. I fixed this.

[kevans]

Seems like a good/sane idea