Paths

Table of Contentst

sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}"
ClosedPublic
Actions

Authored by bcran on Feb 3 2020, 5:21 PM.

Details

Reviewers

tsoome
mat
araujo
manu
mikael

Commits

rP525458: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}"

Summary

Since we now require python 3.4 and newer, use ${PYTHON_CMD} instead of
hard-coding the python version.

Test Plan

Built both flavors in poudriere:

x86_64 report: https://poudriere.bsdio.com:8080/build.html?mastername=current-amd64-freebsd-svn-bsdio&build=2020-02-04_23h51m27s
i386 report: https://poudriere.bsdio.com:8080/build.html?mastername=current-amd64-freebsd-svn-bsdio&build=2020-02-05_00h46m51s

Ran portlint.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bcran created this revision.Feb 3 2020, 5:21 PM

Harbormaster completed remote builds in B29142: Diff 67723.Feb 3 2020, 5:21 PM

bcran retitled this revision from Replace "python2.7" with "${PYTHON_CMD}" and use ${WRKSRC} consistently. to sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}" and use ${WRKSRC} consistently..Feb 3 2020, 5:21 PM

Unfortunately this has broken the port for anyone without python 2.7 installed. Could somebody approve me to commit this fix please?
@araujo @mat ?

And I know there are several problems with the Makefile, which I've learned through my updates to the uefi-edk2-bhyve port. But I'd like to get this fix committed and then, once the changes to uefi-edk2-bhyve are committed I'll fix the issues with this port based on what I've learned.

How are you testing these changes that you didn't catch this problem before?

Please, use poundriere for every change you are making and add the results in the "Test" part of the PHAB review (A link to somewhere with the poundriere tests).

Also those changes for ${BUILD_WRKSRC} to ${WRKSRC} are unnecessary IMHO, changes to PYTHON first and make the port buildable again and avoid more failures seems safer.

This revision now requires changes to proceed.Feb 5 2020, 2:52 AM

In D23486#516054, @araujo wrote:

How are you testing these changes that you didn't catch this problem before?

I was running portlint and just make etc. on my desktop. I'll test using poudriere from now on.

Please, use poundriere for every change you are making and add the results in the "Test" part of the PHAB review (A link to somewhere with the poundriere tests).

ok.

Also those changes for ${BUILD_WRKSRC} to ${WRKSRC} are unnecessary IMHO, changes to PYTHON first and make the port buildable again and avoid more failures seems safer.

That's fair. I'll revert the other changes.

Simplify change to just the PYTHON_CMD fix.

Harbormaster completed remote builds in B29180: Diff 67810.Feb 5 2020, 7:44 AM

bcran retitled this revision from sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}" and use ${WRKSRC} consistently. to sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".Feb 5 2020, 7:58 AM

bcran edited the summary of this revision. (Show Details)

bcran edited the test plan for this revision. (Show Details)

@araujo Could you approve my latest changes please? I ran poudriere and put the successful results at:

LGTM, add the Approved by as usual.

This revision is now accepted and ready to land.Feb 7 2020, 1:44 AM

Closed by commit rP525458: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}" (authored by bcran). · Explain WhyFeb 7 2020, 2:55 AM

This revision was automatically updated to reflect the committed changes.

bcran added a commit: rP525458: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".

Revision Contents
Changeset List

Path

Size

head/

sysutils/

uefi-edk2-qemu/

Makefile

2 lines

Diff 67908

View Options

head/sysutils/uefi-edk2-qemu/Makefile

sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}"ClosedPublicActions