Page MenuHomeFreeBSD

loader: rewrite zfs reader zap code to use malloc
ClosedPublic

Authored by tsoome on Jan 30 2020, 8:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 8:22 PM
Unknown Object (File)
Sat, Jan 18, 4:20 AM
Unknown Object (File)
Tue, Jan 14, 1:44 AM
Unknown Object (File)
Mon, Jan 6, 8:54 PM
Unknown Object (File)
Dec 20 2024, 11:38 AM
Unknown Object (File)
Dec 9 2024, 5:54 PM
Unknown Object (File)
Nov 30 2024, 6:07 PM
Unknown Object (File)
Oct 14 2024, 3:54 PM
Subscribers

Details

Summary

First step on removing zfs_alloc.

Test Plan

I have used this implementation since 21 Nov 2019.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

replace if chain by switch. Print out entire zap_block_type.

LGTM. There are a few minor nits but these are optional.

stand/libsa/zfs/zfsimpl.c
2458 ↗(On Diff #67556)

Nit, optional: 'lp' is passed and from an on-stack variable, we could use it directly, e.g. *lp = malloc(sizeof(**lp)) below.

2609 ↗(On Diff #67556)

Nit, optional: I think it's better to have something like zap_leaf_free() that free's zl->l_phys and zl.

This revision is now accepted and ready to land.Feb 3 2020, 2:49 AM

Suggestions from delphij, thanks!

This revision now requires review to proceed.Feb 3 2020, 5:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2020, 7:38 AM
This revision was automatically updated to reflect the committed changes.