Differential D23233

[PowerPC64] fix crash when using machdep.moea64_bpvo_pool_size tunable
ClosedPublic
Actions

Authored by alfredo on Jan 17 2020, 2:03 PM.

Tags

Referenced Files

	Unknown Object (File)
	Sat, May 25, 9:55 AM

	Unknown Object (File)
	Thu, May 23, 3:54 PM

	Unknown Object (File)
	Dec 20 2023, 6:55 AM

	Unknown Object (File)
	Dec 8 2023, 5:39 AM

	Unknown Object (File)
	Nov 27 2023, 5:10 PM

	Unknown Object (File)
	Nov 11 2023, 10:05 PM

	Unknown Object (File)
	Nov 7 2023, 5:51 PM

	Unknown Object (File)
	Nov 6 2023, 10:04 AM

View All 22 Files

Subscribers

Details

Reviewers

jhibbits
bdragon
nwhitehorn

Commits

rS356896: [PowerPC64] fix crash when using machdep.moea64_bpvo_pool_size tunable

Summary

This fixes kernel crashing when tunable "machdep.moea64_bpvo_pool_size" is set to a value higher then 327680 (default value).
Function moea64_mid_bootstrap() relies on moea64_bpvo_pool_size, but at time of the use the variable wan't yet updated with the new value provided by user.

Problem was detected after trying to use a VM with 64GB of RAM, and default moea64_bpvo_pool_size is insufficient (kernel boot used more than 470000) .
I think default value must be discussed to address this use case, or find a way to calculate pool size automatically based on amount of memory detected.

Test Plan

Tested on QEMU VM with 64GB of RAM using "set machdep.moea64_bpvo_pool_size=655360" on loader prompt

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28732
Build 26747: arc lint + arc unit

Event Timeline

alfredo created this revision.Jan 17 2020, 2:03 PM

Herald added a subscriber: luporl. · View Herald TranscriptJan 17 2020, 2:03 PM

Harbormaster completed remote builds in B28732: Diff 66909.Jan 17 2020, 2:03 PM

jhibbits added inline comments.Jan 17 2020, 5:27 PM

sys/powerpc/aim/mmu_oea64.c
917	Having this here, shouldn't you delete the TUNABLE_INT() above on line 188?

This revision was not accepted when it landed; it landed in state Needs Review.Jan 19 2020, 9:18 PM

Closed by commit rS356896: [PowerPC64] fix crash when using machdep.moea64_bpvo_pool_size tunable (authored by jhibbits). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhibbits added a commit: rS356896: [PowerPC64] fix crash when using machdep.moea64_bpvo_pool_size tunable.

Herald added a subscriber: imp. · View Herald TranscriptJan 19 2020, 9:18 PM

Revision Contents
Changeset List

Path

Size

sys/

powerpc/

aim/

3 lines

Diff 66909

sys/powerpc/aim/mmu_oea64.c

Loading...