Page MenuHomeFreeBSD
Differential D23233

[PowerPC64] fix crash when using machdep.moea64_bpvo_pool_size tunable
ClosedPublic
Actions

Authored by alfredo on Jan 17 2020, 2:03 PM.
Tags
Referenced Files
Unknown Object (File)
Thu, Jan 23, 2:19 AM
Unknown Object (File)
Nov 18 2024, 11:47 PM
Unknown Object (File)
Sep 16 2024, 11:56 AM
Unknown Object (File)
Sep 8 2024, 6:45 AM
Unknown Object (File)
Sep 7 2024, 7:29 AM
Unknown Object (File)
Sep 5 2024, 12:04 AM
Unknown Object (File)
Aug 31 2024, 9:14 PM
Unknown Object (File)
Aug 29 2024, 10:41 PM
View All 38 Files
Subscribers
imp
luporl

Details

Reviewers
jhibbits
bdragon
nwhitehorn
Commits
rS356896: [PowerPC64] fix crash when using machdep.moea64_bpvo_pool_size tunable
Summary

This fixes kernel crashing when tunable "machdep.moea64_bpvo_pool_size" is set to a value higher then 327680 (default value).
Function moea64_mid_bootstrap() relies on moea64_bpvo_pool_size, but at time of the use the variable wan't yet updated with the new value provided by user.

Problem was detected after trying to use a VM with 64GB of RAM, and default moea64_bpvo_pool_size is insufficient (kernel boot used more than 470000) .
I think default value must be discussed to address this use case, or find a way to calculate pool size automatically based on amount of memory detected.

Test Plan

Tested on QEMU VM with 64GB of RAM using "set machdep.moea64_bpvo_pool_size=655360" on loader prompt

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alfredo created this revision.Jan 17 2020, 2:03 PM
Herald added a subscriber: luporl. · View Herald TranscriptJan 17 2020, 2:03 PM
Harbormaster completed remote builds in B28732: Diff 66909.Jan 17 2020, 2:03 PM
jhibbits added inline comments.Jan 17 2020, 5:27 PM
sys/powerpc/aim/mmu_oea64.c
917 ↗(On Diff #66909)

Having this here, shouldn't you delete the TUNABLE_INT() above on line 188?

This revision was not accepted when it landed; it landed in state Needs Review.Jan 19 2020, 9:18 PM
Closed by commit rS356896: [PowerPC64] fix crash when using machdep.moea64_bpvo_pool_size tunable (authored by jhibbits). · Explain Why
This revision was automatically updated to reflect the committed changes.
jhibbits added a commit: rS356896: [PowerPC64] fix crash when using machdep.moea64_bpvo_pool_size tunable.
Herald added a subscriber: imp. · View Herald TranscriptJan 19 2020, 9:18 PM

Revision Contents
Changeset List

PathSize
head/
sys/
powerpc/
aim/
10 lines

Diff 67028

View Options

head/sys/powerpc/aim/mmu_oea64.c

Loading...