Page MenuHomeFreeBSD

retire BSD_CRTBEGIN option
AcceptedPublic

Authored by emaste on Fri, Jan 10, 5:04 PM.

Details

Summary

BSD_CRTBEGIN is enabled on all archs (except sparc64) and non-BSD csu will be removed along with gcc 4.2.1.

This change will not be committed until one of the following is true:

  • someone adds sparc64 support to BSD_CRTBEGIN
  • we reach the gcc 4.2.1 removal date and leave sparc64 broken
  • there is a decision to proceed with this earlier than gcc 4.2.1 removal, leaving sparc64 broken but with the hope that it gets fixed

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

emaste created this revision.Fri, Jan 10, 5:04 PM
emaste added a reviewer: sjg.Fri, Jan 10, 5:05 PM
emaste added a subscriber: sjg.

@sjg I did not change all of the .depend files, I assume they can be regenerated and committed after this change gets in

sjg added a comment.Fri, Jan 10, 5:19 PM

There should not be any active depends mentioning gnu/lib/csu - that's the point of the filters,
any stale entries will be ignored - if the directory is gone.

contrib/bmake/mk/meta2deps.sh
52

I would skip this one - its just an example

share/mk/meta2deps.sh
52

again just an example

emaste added inline comments.Fri, Jan 10, 5:23 PM
contrib/bmake/mk/meta2deps.sh
52

Sure it's just an example but once gnu/lib/csu is gone it might be confusing rather than informative

brooks accepted this revision.Fri, Jan 10, 10:08 PM
brooks added a subscriber: brooks.

LGTM

This revision is now accepted and ready to land.Fri, Jan 10, 10:08 PM
andrew accepted this revision.Sun, Jan 12, 5:15 PM

there is a decision to proceed with this earlier than gcc 4.2.1 removal, leaving sparc64 broken but with the hope that it gets fixed

@imp proposed a new timeline on the -arch mailing list which has sparc64 removal moved to 2020-01-31. Regardless of whether that happens or not I think it's a fair date for this change.