Page MenuHomeFreeBSD
Differential D23068

Do not define TCPOUTFLAGS in rack_bbr_common.c
ClosedPublic
Actions

Authored by emaste on Jan 7 2020, 5:09 PM.

Details

Reviewers
rrs
tuexen
Group Reviewers
transport
Commits
rS356459: Do not define TCPOUTFLAGS in rack_bbr_common
Summary

tcp_outflags isn't used in this source file and compilation failed with external GCC on sparc64 with:

In file included from .../rack_bbr_common.c:96:0:
.../tcp_fsm.h:88:15: error: 'tcp_outflags' defined but not used ...

static u_char tcp_outflags[TCP_NSTATES] = {
              ^~~~~~~~~~~~

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emaste created this revision.Jan 7 2020, 5:09 PM
tuexen accepted this revision.Jan 7 2020, 5:36 PM
This revision is now accepted and ready to land.Jan 7 2020, 5:36 PM
Closed by commit rS356459: Do not define TCPOUTFLAGS in rack_bbr_common (authored by emaste). · Explain WhyJan 7 2020, 5:57 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rS356459: Do not define TCPOUTFLAGS in rack_bbr_common.

Revision Contents
Changeset List

Diff 66452

View Options

head/sys/netinet/tcp_stacks/rack_bbr_common.c

Loading...