- Don't take a ref in rt_exportinfo(). This was quite wrong in that we took the ref even when NHR_REF was not set.
- Don't unconditionally take a ref in rtrequest1_fib(). rt_getifa_fib() will acquire a reference, in which case we would previously acquire two references.
- Stop taking a reference in rtinit1() before calling rtrequest1_fib(). rtrequest1_fib() will acquire a reference for the RTM_ADD case.
This fixes a memory leak observed when removing an interface address.
I would appreciate any testing that others can provide.
I'm afraid I don't. I added some dtrace probes to ifa_ref() and friends to help debug the issue and looked at the vmstat -m stats to verify the change, but it was all ad-hoc.
|909 ↗||(On Diff #65930)|
I guess it would be formally correct to take a ref in the NHR_REF case, though no existing callers care. I will do that and make sure we release the reference.