Page MenuHomeFreeBSD

Deduplicate code between if_delgroup() and if_delgroups().
ClosedPublic

Authored by markj on Dec 20 2019, 5:15 PM.

Details

Summary

Fix some style in if_addgroup(). No functional change intended.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

hselasky added inline comments.
sys/net/if.c
1510 ↗(On Diff #65862)

Maybe call this function _if_delgroup_wlocked() because it is called locked?

This revision is now accepted and ready to land.Dec 20 2019, 5:22 PM

Give _if_delgroup() a slightly more descriptive name.

This revision now requires review to proceed.Dec 20 2019, 5:28 PM
hselasky added inline comments.
sys/net/if.c
1582 ↗(On Diff #65863)

Technically this is the same like:
while ((ifgl = CK_STAILQ_FIRST(&ifp->if_groups)) != NULL) {

This revision is now accepted and ready to land.Dec 20 2019, 5:31 PM

Simplify the loop header in if_delgroups().

This revision now requires review to proceed.Dec 20 2019, 5:41 PM
This revision is now accepted and ready to land.Dec 20 2019, 5:42 PM