Page MenuHomeFreeBSD

Add doxygen settings to Mk/Uses
AbandonedPublic

Authored by dteske on Mon, Dec 2, 4:01 AM.

Details

Reviewers
imp
mat
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Summary

Some ports require doxygen to compile.
sysutils/cmocka for example complains about not having doxygen.

Test Plan

Add "USES=doxygen" to existing uses on sysutils/cmocka for testing.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27880
Build 26051: arc lint + arc unit

Event Timeline

dteske created this revision.Mon, Dec 2, 4:01 AM
adamw added a comment.Mon, Dec 2, 1:05 PM

I'm missing something. Are there multiple ports that provide doxygen binaries?

bapt added a subscriber: bapt.Mon, Dec 2, 1:07 PM

What is the point about adding this uses?

bapt added a comment.Mon, Dec 2, 1:09 PM

I mean it bring nothing that a regular BUILD_DEPENDS inside the port itself can achieve easily

mat added a comment.Mon, Dec 2, 1:59 PM

That is only one line of code worth. What problem are you trying to solve?

Mk/Uses/doxygen.mk
6

Why create a variable, it is only used once.

8

Should probably be:

BUILD_DEPENDS+= doxygen:${_DOXYGEN_PORT}
dteske added a comment.Mon, Dec 2, 3:11 PM
In D22628#495001, @mat wrote:

That is only one line of code worth. What problem are you trying to solve?

A lot of R-cran packages use doxygen. These R packages can sometimes be rather picky about the doxygen version, and so it becomes rather nice to be able to say USES=doxygen in the port Makefile and override _DOXYGEN_PORT in make.conf

Mk/Uses/doxygen.mk
6

To allow it to be overridden in make.conf

8

If that works, great, but I was just following the other similar settings in the file

mat added a comment.Mon, Dec 2, 5:02 PM

A lot of R-cran packages use doxygen. These R packages can sometimes be rather picky about the doxygen version, and so it becomes rather nice to be able to say USES=doxygen in the port Makefile and override _DOXYGEN_PORT in make.conf

There is only one version of doxygen in the ports tree, and this seems to be specific R, so if something like this ever comes to live, it should probably happen within USES=cran.

Mk/Uses/doxygen.mk
6

But that variable is not overridable in make.conf.

8

Well, you were depending upon the existence of a file, not about the existence of a binary to run things. Unless the problem you are trying to solve requires the exitence of that file but does not need to execute it, you're ok. If you are trying to say "this ports needs to run doxygen", your version is wrong.

dteske added a comment.Mon, Dec 2, 6:10 PM
In D22628#495001, @mat wrote:

That is only one line of code worth. What problem are you trying to solve?

A lot of R-cran packages use doxygen. These R packages can sometimes be rather picky about the doxygen version, and so it becomes rather nice to be able to say USES=doxygen in the port Makefile and override _DOXYGEN_PORT in make.conf

In D22628#495048, @mat wrote:

A lot of R-cran packages use doxygen. These R packages can sometimes be rather picky about the doxygen version, and so it becomes rather nice to be able to say USES=doxygen in the port Makefile and override _DOXYGEN_PORT in make.conf

There is only one version of doxygen in the ports tree, and this seems to be specific R, so if something like this ever comes to live, it should probably happen within USES=cran.

Only one version of doxygen at the head of the official ports tree, yes.

I do like your suggestion of handling this in cran when it is needed.

I can abandon this for now. Thanks for the review.

dteske added inline comments.Mon, Dec 2, 6:11 PM
Mk/Uses/doxygen.mk
6

Ah, didn't know that. Thanks.

dteske abandoned this revision.Mon, Dec 2, 6:11 PM