Tested on: amd64 (amd64, i386, linux64), i386 (i386, linux)
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
sys/amd64/linux/linux_sysvec.c | ||
---|---|---|
323 ↗ | (On Diff #64418) | if (error != 0) for all places |
sys/kern/kern_exec.c | ||
363 ↗ | (On Diff #64418) | stack_base almost cries to become uintptr_t, and you are touching almost all places which need explicit type for it. Then at least some casts could be removed, like sv_setregs calls. But I do not insist. |
sys/kern/kern_exec.c | ||
---|---|---|
363 ↗ | (On Diff #64418) | Or a char *, but uintptr_t is probably fine. I actually planned to make this change as a followup as part of some other cleanup I am doing. I will do that as a followup change. |