Page MenuHomeFreeBSD

Fix build race in bsd.files.mk
ClosedPublic

Authored by arichardson on Fri, Nov 15, 3:45 PM.

Details

Summary

We need to ensure that installdirs-FOO runs before installfiles-FOO since
otherwise the directory may not exist when we attempt to install the target.
This was randomly causing failures in our Jenkins instance when installing
drti.o in cddl/lib/drti.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

arichardson created this revision.Fri, Nov 15, 3:45 PM
brooks accepted this revision.Fri, Nov 15, 6:08 PM

LGTM

This revision is now accepted and ready to land.Fri, Nov 15, 6:08 PM
This revision was automatically updated to reflect the committed changes.
sjg added inline comments.Tue, Nov 19, 1:19 AM
head/share/mk/bsd.files.mk
119

I would be more inclined to use ${.ALLSRC:Ninstalldirs-*} rather than assume order of .ALLSRC