Use an array of handlers in the data and instruction aborts
ClosedPublic
Actions

Authored by andrew on Oct 28 2019, 11:59 AM.

Details

Reviewers

jhibbits
manu

Group Reviewers

arm64

Commits

rS354174: Use an array of handlers in the data and instruction aborts

Summary

Previously we would call data_abort on all data and instruction aborts
however this is incorrect for most abort types. Move to use an array
of function pointers to allow for more handlers to be easily added.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Oct 28 2019, 11:59 AM

Herald added a reviewer: manu. · View Herald TranscriptOct 28 2019, 11:59 AM

Herald added a subscriber: emaste. · View Herald Transcript

Harbormaster completed remote builds in B27241: Diff 63725.Oct 28 2019, 11:59 AM

andrew mentioned this in D22133: ARM64: Treat alignment faults as bus errors.Oct 28 2019, 12:04 PM

jhibbits accepted this revision.Oct 28 2019, 5:20 PM

This revision is now accepted and ready to land.Oct 28 2019, 5:20 PM

Closed by commit rS354174: Use an array of handlers in the data and instruction aborts (authored by andrew). · Explain WhyOct 30 2019, 10:43 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rS354174: Use an array of handlers in the data and instruction aborts.

Herald added a subscriber: imp. · View Herald TranscriptOct 30 2019, 10:43 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

arm64/

trap.c

51 lines

Diff 63786

View Options

head/sys/arm64/arm64/trap.c

Use an array of handlers in the data and instruction abortsClosedPublicActions