Page MenuHomeFreeBSD
Differential D22148

Add SPI driver for Rockchip platform
ClosedPublic
Actions

Authored by gonzo on Oct 24 2019, 10:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 10:31 PM
Unknown Object (File)
Fri, Nov 22, 10:07 PM
Unknown Object (File)
Thu, Nov 21, 12:12 AM
Unknown Object (File)
Sat, Nov 16, 2:04 PM
Unknown Object (File)
Sat, Nov 16, 7:37 AM
Unknown Object (File)
Wed, Nov 13, 7:12 PM
Unknown Object (File)
Mon, Nov 11, 2:35 AM
Unknown Object (File)
Thu, Nov 7, 8:19 AM
View All 57 Files
Subscribers
andrew
emaste
imp

Details

Reviewers
• ian
manu
Commits
rS358641: MFC r354087, r354089, r354094, r354100, r354103, r354152
rS354103: arm64: rk3399: add SPI driver and include it in GENERIC config
Summary

SPI driver for Rockchip IP works only in PIO mode for now. DMA is not supported yet.
For now the driver supports only RK3399 compatibility string but it should work with older SoCs too.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27211
Build 25476: arc lint + arc unit

Event Timeline

gonzo created this revision.Oct 24 2019, 10:07 PM
Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptOct 24 2019, 10:07 PM
Harbormaster completed remote builds in B27210: Diff 63653.Oct 24 2019, 10:07 PM
gonzo updated this revision to Diff 63654.Oct 24 2019, 10:11 PM

Add GENERIC config change

Harbormaster completed remote builds in B27211: Diff 63654.Oct 24 2019, 10:11 PM
gonzo updated this revision to Diff 63668.Oct 25 2019, 5:02 PM

Add clocks bit

Harbormaster completed remote builds in B27221: Diff 63668.Oct 25 2019, 5:02 PM
manu added inline comments.Oct 25 2019, 5:16 PM
sys/arm64/rockchip/clk/rk3399_cru.c
1587 ↗(On Diff #63668)

hack leftovers.

1618 ↗(On Diff #63668)

hack leftovers.

manu added inline comments.Oct 25 2019, 5:54 PM
sys/arm64/rockchip/rk_spi.c
151

IP only have CS0 and CS1, we should add a checks here and return EINVAL

192

Is this needed ?
and if it is why not doing the same for the rxfifo ?

gonzo updated this revision to Diff 63670.Oct 25 2019, 6:34 PM

Remove hack leftovers

Harbormaster completed remote builds in B27223: Diff 63670.Oct 25 2019, 6:34 PM
gonzo marked 2 inline comments as done.Oct 25 2019, 6:34 PM
gonzo added inline comments.
sys/arm64/rockchip/rk_spi.c
192

This is what Linux driver does and I think it's to handle SPI chips on older SoCs. RX fifo has the same size as TX fifo AFAIK, so there is no need to do it twice.

gonzo updated this revision to Diff 63677.Oct 25 2019, 8:16 PM

Check value of CS and return EINVAL if it's more than max

Harbormaster completed remote builds in B27226: Diff 63677.Oct 25 2019, 8:16 PM
manu accepted this revision.Oct 25 2019, 8:26 PM

OK for me.
If you could split the commits between clocks and driver that would be great.

This revision is now accepted and ready to land.Oct 25 2019, 8:26 PM
Closed by commit rS354103: arm64: rk3399: add SPI driver and include it in GENERIC config (authored by svnmir). · Explain WhyOct 25 2019, 9:38 PM
This revision was automatically updated to reflect the committed changes.
svnmir added a commit: rS354103: arm64: rk3399: add SPI driver and include it in GENERIC config.
manu added a commit: rS358641: MFC r354087, r354089, r354094, r354100, r354103, r354152.Mar 4 2020, 8:48 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
conf/
1 line
rockchip/
480 lines
conf/
1 line

Diff 63654

View Options

sys/arm64/conf/GENERIC

Loading...
View Options

sys/arm64/rockchip/rk_spi.c

Loading...
View Options

sys/conf/files.arm64

Loading...