Page MenuHomeFreeBSD

Building head on 11 needs libzstd
AcceptedPublic

Authored by sjg on Oct 24 2019, 12:54 AM.

Details

Summary

Building libzstd during build-tools requires
usr/include/private/zstd to have been made
under $WORLDTMP/legacy

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 27207
Build 25473: arc lint + arc unit

Event Timeline

sjg created this revision.Oct 24 2019, 12:54 AM
sjg updated this revision to Diff 63617.Oct 24 2019, 12:56 AM

Trim usr/include

Should addition of libzstd to _elftoolchain_libs be conditional on something?

emaste added inline comments.Oct 24 2019, 1:26 PM
Makefile.inc1
2364

I think this could be in the same BOOTSTRAPPING conditional as the existing _elftoolchain_libs?

tools/build/Makefile
132–133

can commit this separately I think

imp added inline comments.Oct 24 2019, 3:50 PM
Makefile.inc1
2364

Or just add it to the existing _elftoolchain_libs?

tools/build/Makefile
132–133

Agreed. It's a good change, just not relevant.

emaste added inline comments.Oct 24 2019, 3:56 PM
Makefile.inc1
2364

yes if it fits on the same line

sjg added inline comments.Oct 24 2019, 7:35 PM
tools/build/Makefile
132–133

Well the addition of usr/include/private/zstd is key ;-)

sjg updated this revision to Diff 63646.Oct 24 2019, 7:40 PM

Shift addition to _elftoolchain_libs

sjg marked an inline comment as done.Oct 24 2019, 7:41 PM
emaste added a reviewer: kib.Oct 24 2019, 7:47 PM
emaste added inline comments.
tools/build/Makefile
132–133

Ah, indeed.

You could rework the installdirs: target in a first commit and have the zstd fix just add the new directory and _elftoolchain_libs entry if you want, or at least call it out in the commit message.

emaste accepted this revision.Oct 24 2019, 7:48 PM
This revision is now accepted and ready to land.Oct 24 2019, 7:48 PM
bapt accepted this revision.Oct 28 2019, 12:58 PM

I was about to commit the same change.