Page MenuHomeFreeBSD

Building head on 11 needs libzstd
AcceptedPublic

Authored by sjg on Oct 24 2019, 12:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 22 2023, 10:41 PM
Unknown Object (File)
Dec 20 2023, 7:05 AM
Unknown Object (File)
Dec 3 2023, 12:57 AM
Unknown Object (File)
Nov 28 2023, 1:22 PM
Unknown Object (File)
Nov 28 2023, 12:46 AM
Unknown Object (File)
Oct 3 2023, 4:32 PM
Unknown Object (File)
Apr 25 2023, 6:58 PM
Unknown Object (File)
Apr 8 2023, 12:33 AM
Subscribers

Details

Summary

Building libzstd during build-tools requires
usr/include/private/zstd to have been made
under $WORLDTMP/legacy

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27207
Build 25473: arc lint + arc unit

Event Timeline

Should addition of libzstd to _elftoolchain_libs be conditional on something?

Makefile.inc1
2364

I think this could be in the same BOOTSTRAPPING conditional as the existing _elftoolchain_libs?

tools/build/Makefile
132–133

can commit this separately I think

Makefile.inc1
2364

Or just add it to the existing _elftoolchain_libs?

tools/build/Makefile
132–133

Agreed. It's a good change, just not relevant.

Makefile.inc1
2364

yes if it fits on the same line

tools/build/Makefile
132–133

Well the addition of usr/include/private/zstd is key ;-)

Shift addition to _elftoolchain_libs

sjg marked an inline comment as done.Oct 24 2019, 7:41 PM
emaste added inline comments.
tools/build/Makefile
132–133

Ah, indeed.

You could rework the installdirs: target in a first commit and have the zstd fix just add the new directory and _elftoolchain_libs entry if you want, or at least call it out in the commit message.

This revision is now accepted and ready to land.Oct 24 2019, 7:48 PM

I was about to commit the same change.