Page MenuHomeFreeBSD
Differential D21992

Restore nofaulting operations after r352807
ClosedPublic
Actions

Authored by kib on Oct 12 2019, 3:27 PM.
Tags
None
Referenced Files
F136325341: D21992.diff
Mon, Nov 17, 5:50 AM
Unknown Object (File)
Sun, Nov 9, 4:34 PM
Unknown Object (File)
Sun, Nov 9, 6:51 AM
Unknown Object (File)
Sun, Nov 9, 4:29 AM
Unknown Object (File)
Sat, Nov 8, 9:44 PM
Unknown Object (File)
Sat, Nov 8, 12:33 PM
Unknown Object (File)
Sat, Nov 8, 10:35 AM
Unknown Object (File)
Sat, Nov 8, 2:43 AM
View All Files
Subscribers
imp
pho

Details

Reviewers
alc
markj
Commits
rS353463: Restore nofaulting operations after r352807
Summary

The TDP_NOFAULTING flag should be checked in vm_fault(), not in vm_fault_trap(). Otherwise kernel accesses to userspace like vn_io_fault() enter vm locking.

Reported by: pho

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Oct 12 2019, 3:27 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 12 2019, 3:27 PM
Harbormaster completed remote builds in B26997: Diff 63180.Oct 12 2019, 3:27 PM
kib edited the summary of this revision. (Show Details)Oct 12 2019, 3:47 PM
kib added reviewers: alc, markj.
kib added a subscriber: pho.
alc added inline comments.Oct 12 2019, 4:48 PM
sys/vm/vm_fault.c
561 ↗(On Diff #63180)

This is now only used under KTRACE. I suspect that using curthread directly in those two places will be cheaper than using a callee-saves register for td.

alc accepted this revision.Oct 12 2019, 4:48 PM
This revision is now accepted and ready to land.Oct 12 2019, 4:48 PM
kib updated this revision to Diff 63189.Oct 12 2019, 5:31 PM

Stop using td in vm_fault_trap(), use curthread.

This revision now requires review to proceed.Oct 12 2019, 5:31 PM
Harbormaster completed remote builds in B27004: Diff 63189.Oct 12 2019, 5:31 PM
kib marked an inline comment as done.Oct 12 2019, 5:32 PM
markj accepted this revision.Oct 12 2019, 5:42 PM
This revision is now accepted and ready to land.Oct 12 2019, 5:42 PM
alc accepted this revision.Oct 12 2019, 5:44 PM
Closed by commit rS353463: Restore nofaulting operations after r352807 (authored by kib). · Explain WhyOct 13 2019, 6:57 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rS353463: Restore nofaulting operations after r352807.

Revision Contents
Changeset List

PathSize
head/
sys/
vm/
12 lines

Diff 63207

View Options

head/sys/vm/vm_fault.c

Loading...