Page MenuHomeFreeBSD

Restore nofaulting operations after r352807
ClosedPublic

Authored by kib on Oct 12 2019, 3:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 1:00 PM
Unknown Object (File)
Mar 17 2024, 5:28 AM
Unknown Object (File)
Feb 18 2024, 7:42 PM
Unknown Object (File)
Feb 1 2024, 10:59 AM
Unknown Object (File)
Dec 23 2023, 2:07 AM
Unknown Object (File)
Dec 20 2023, 4:30 PM
Unknown Object (File)
Sep 13 2023, 7:17 AM
Unknown Object (File)
Jul 6 2023, 12:40 AM
Subscribers

Details

Summary

The TDP_NOFAULTING flag should be checked in vm_fault(), not in vm_fault_trap(). Otherwise kernel accesses to userspace like vn_io_fault() enter vm locking.

Reported by: pho

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 26997

Event Timeline

kib added reviewers: alc, markj.
kib added a subscriber: pho.
sys/vm/vm_fault.c
561

This is now only used under KTRACE. I suspect that using curthread directly in those two places will be cheaper than using a callee-saves register for td.

This revision is now accepted and ready to land.Oct 12 2019, 4:48 PM

Stop using td in vm_fault_trap(), use curthread.

This revision now requires review to proceed.Oct 12 2019, 5:31 PM
kib marked an inline comment as done.Oct 12 2019, 5:32 PM
This revision is now accepted and ready to land.Oct 12 2019, 5:42 PM
This revision was automatically updated to reflect the committed changes.