Page MenuHomeFreeBSD

nvdimm(4): Add description of NVDIMM Namespace support
ClosedPublic

Authored by scottph on Thu, Sep 5, 6:37 PM.

Details

Summary

Sponsored by: Intel Corporation
MFC after: 3 days

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

scottph created this revision.Thu, Sep 5, 6:37 PM
bcr added a subscriber: bcr.Thu, Sep 5, 7:06 PM

Can you run textproc/igor and "mandoc -Tlint" over your man page changes? It will report a few things like that you need a line break after a sentence stop.

kib accepted this revision.Thu, Sep 5, 7:15 PM
kib added a reviewer: emaste.
kib added inline comments.
share/man/man4/nvdimm.4
90 ↗(On Diff #61699)

I think 'Additionally' is excessive there. Namespaces are part of the basic functionality.

This revision is now accepted and ready to land.Thu, Sep 5, 7:15 PM
emaste added a comment.Thu, Sep 5, 7:51 PM

Content seems fine, I think it's fine to commit after igor/mandoc -Tlint updates.

scottph updated this revision to Diff 61706.Thu, Sep 5, 8:00 PM
This revision now requires review to proceed.Thu, Sep 5, 8:00 PM
emaste accepted this revision.Thu, Sep 5, 8:09 PM
This revision is now accepted and ready to land.Thu, Sep 5, 8:09 PM
kib accepted this revision.Thu, Sep 5, 8:16 PM
bcr accepted this revision.Thu, Sep 5, 8:24 PM

OK from manpages. Thank you!

This revision was automatically updated to reflect the committed changes.
scottph marked an inline comment as done.