Page MenuHomeFreeBSD

vfs: remove flags argument from VOP_UNLOCK
ClosedPublic

Authored by mjg on Aug 27 2019, 5:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 4:45 PM
Unknown Object (File)
Mon, Dec 9, 12:31 PM
Unknown Object (File)
Sun, Dec 1, 5:56 AM
Unknown Object (File)
Sep 27 2024, 2:59 PM
Unknown Object (File)
Sep 24 2024, 8:42 PM
Unknown Object (File)
Sep 24 2024, 8:42 PM
Unknown Object (File)
Sep 20 2024, 5:20 AM
Unknown Object (File)
Sep 16 2024, 9:17 PM
Subscribers

Details

Summary

Below is the only material part of the change, the rest was mostly autogenerated with coccinelle and can be found here:

https://people.freebsd.org/~mjg/vop-unlock-flags-removal.diff

Test Plan

universe
ports exprun

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 26124

Event Timeline

kib added inline comments.
sys/kern/vfs_subr.c
4888

Remove this empty _post method ?

This revision is now accepted and ready to land.Aug 27 2019, 3:53 PM

As expected several ports failed, unfortunately some of them have rather nasty code which will require a lot of care and testing.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240156

most notably open-vm-tools has copy-pasted and modified old variant of null_unlock. Thus removal of the flags argument will wait a little bit until I get around to sorting this out.

Can you post the coccinelle script used somewhere? Thanks.