Page MenuHomeFreeBSD
Differential D21427

vfs: remove flags argument from VOP_UNLOCK
ClosedPublic
Actions

Authored by mjg on Aug 27 2019, 5:55 AM.
Tags
None
Referenced Files
F87580280: D21427.diff
Fri, Jul 5, 9:09 AM
Unknown Object (File)
Mon, Jul 1, 5:23 PM
Unknown Object (File)
Mon, Jul 1, 4:48 PM
Unknown Object (File)
Mon, Jul 1, 4:48 PM
Unknown Object (File)
Mon, Jul 1, 3:59 PM
Unknown Object (File)
Sun, Jun 30, 9:56 PM
Unknown Object (File)
Sun, Jun 23, 1:36 PM
Unknown Object (File)
Feb 23 2024, 12:08 PM
View All 31 Files
Subscribers
cem
emaste
imp

Details

Reviewers
kib
Commits
rS356337: vfs: drop the mostly unused flags argument from VOP_UNLOCK
Summary

Below is the only material part of the change, the rest was mostly autogenerated with coccinelle and can be found here:

https://people.freebsd.org/~mjg/vop-unlock-flags-removal.diff

Test Plan

universe
ports exprun

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 26124

Event Timeline

mjg created this revision.Aug 27 2019, 5:55 AM
Herald added a subscriber: imp. · View Herald TranscriptAug 27 2019, 5:55 AM
Harbormaster completed remote builds in B26124: Diff 61337.Aug 27 2019, 5:55 AM
mjg added a parent revision: D21426: vfs: stop passing LK_INTERLOCK to VOP_UNLOCK.Aug 27 2019, 5:59 AM
kib accepted this revision.Aug 27 2019, 3:53 PM
kib added inline comments.
sys/kern/vfs_subr.c
4888

Remove this empty _post method ?

This revision is now accepted and ready to land.Aug 27 2019, 3:53 PM
emaste added a subscriber: emaste.Sep 1 2019, 12:56 AM
mjg added a comment.Sep 3 2019, 12:05 PM

As expected several ports failed, unfortunately some of them have rather nasty code which will require a lot of care and testing.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240156

most notably open-vm-tools has copy-pasted and modified old variant of null_unlock. Thus removal of the flags argument will wait a little bit until I get around to sorting this out.

cem added a subscriber: cem.Sep 12 2019, 10:27 PM

Can you post the coccinelle script used somewhere? Thanks.

mjg closed this revision.Jan 3 2020, 10:36 PM

https://svnweb.freebsd.org/base?view=revision&revision=356337

mjg added a commit: rS356337: vfs: drop the mostly unused flags argument from VOP_UNLOCK.Jan 4 2020, 6:39 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
5 lines
4 lines
7 lines
1 line

Diff 61337

View Options

sys/kern/vfs_default.c

Loading...
View Options

sys/kern/vfs_lookup.c

Loading...
View Options

sys/kern/vfs_subr.c

Loading...
View Options

sys/kern/vnode_if.src

Loading...