Page MenuHomeFreeBSD

vfs: remove flags argument from VOP_UNLOCK
AcceptedPublic

Authored by mjg on Aug 27 2019, 5:55 AM.

Details

Reviewers
kib
Summary

Below is the only material part of the change, the rest was mostly autogenerated with coccinelle and can be found here:

https://people.freebsd.org/~mjg/vop-unlock-flags-removal.diff

Test Plan

universe
ports exprun

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 26124

Event Timeline

mjg created this revision.Aug 27 2019, 5:55 AM
kib accepted this revision.Aug 27 2019, 3:53 PM
kib added inline comments.
sys/kern/vfs_subr.c
4888

Remove this empty _post method ?

This revision is now accepted and ready to land.Aug 27 2019, 3:53 PM
emaste added a subscriber: emaste.Sep 1 2019, 12:56 AM
mjg added a comment.Sep 3 2019, 12:05 PM

As expected several ports failed, unfortunately some of them have rather nasty code which will require a lot of care and testing.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240156

most notably open-vm-tools has copy-pasted and modified old variant of null_unlock. Thus removal of the flags argument will wait a little bit until I get around to sorting this out.

cem added a subscriber: cem.Sep 12 2019, 10:27 PM

Can you post the coccinelle script used somewhere? Thanks.