vfs: stop passing LK_INTERLOCK to VOP_UNLOCK
ClosedPublic
Actions

Authored by mjg on Aug 27 2019, 5:21 AM.

Tags

None

Referenced Files

	F163893457: D21426.id.diff
	Sun, Jul 26, 11:36 PM

	Unknown Object (File)
	Fri, Jul 24, 4:48 PM

	Unknown Object (File)
	Wed, Jul 22, 8:18 PM

	Unknown Object (File)
	Mon, Jul 20, 10:57 PM

	Unknown Object (File)
	Sat, Jul 18, 3:08 AM

	Unknown Object (File)
	Sun, Jul 5, 12:51 AM

	Unknown Object (File)
	Jun 26 2026, 3:34 PM

	Unknown Object (File)
	Jun 26 2026, 1:38 PM

View All Files

Subscribers

None

Details

Reviewers

kib

Summary

Apparently I missed 3 places which do it (ignoring unionfs). Patch below imo does the trick just fine with holding the interlock across the call. If that's seen as a problem I can hold/drop around it.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

add unionfs patch

mjg added a child revision: D21427: vfs: remove flags argument from VOP_UNLOCK.Aug 27 2019, 5:59 AM

kib accepted this revision.Aug 27 2019, 3:58 PM

This revision is now accepted and ready to land.Aug 27 2019, 3:58 PM

https://svnweb.freebsd.org/base?view=revision&revision=351555
https://svnweb.freebsd.org/base?view=revision&revision=351556

Revision Contents
Changeset List

Path

Size

sys/

fs/

unionfs/

union_vnops.c

34 lines

kern/

vfs_subr.c

10 lines

Diff 61336

View Options

sys/fs/unionfs/union_vnops.c