Page MenuHomeFreeBSD

Turn off -Werror for gcc 4.2.1
ClosedPublic

Authored by imp on Aug 23 2019, 3:31 PM.

Details

Summary

As part of marching gcc 4.2.1 out of the tree, turn off -Werror on gcc 4.2.1
compiles by default. It generates too many false positives and breaks CI
for no benefit.

Discussed on: arch@

this was spurred on by the stupid const cast away DECONST patches.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp created this revision.Aug 23 2019, 3:31 PM
imp edited the summary of this revision. (Show Details)
imp added inline comments.Aug 23 2019, 3:34 PM
sys/conf/kern.pre.mk
96 ↗(On Diff #61162)

here and below need to kill trailing ).

imp added inline comments.Aug 23 2019, 3:38 PM
sys/conf/kern.pre.mk
97 ↗(On Diff #61162)

convention says there should be a tab here (and below) will do (from allanjude)

imp updated this revision to Diff 61163.Aug 23 2019, 3:39 PM

nits noted

imp added a comment.Aug 23 2019, 3:43 PM

Passes MALTA kernel build.
Passes MALTA64 kernel build.
Passes powerpc GENERIC build.

imp updated this revision to Diff 61165.Aug 23 2019, 3:49 PM

add Turn off -Werror for gcc 4.2.1 for userland

jhb accepted this revision.Aug 23 2019, 3:51 PM
This revision is now accepted and ready to land.Aug 23 2019, 3:51 PM
emaste accepted this revision.Aug 23 2019, 3:56 PM
pfg accepted this revision.Aug 23 2019, 4:00 PM
This revision was automatically updated to reflect the committed changes.