if_tuntap: minor improvements
ClosedPublic
Actions

Authored by vmaffione on Aug 17 2019, 1:12 PM.

Details

Reviewers

kevans
markj

Commits

rS351220: if_tuntap: minor improvements

Summary

Rewrite a loop to avoid duplicating the exit condition.
Simplify mask processing in tunpoll().
Fix minor typos.

Test Plan

Tested with a bhyve tap configuration on HEAD.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

vmaffione created this revision.Aug 17 2019, 1:12 PM

Herald added a subscriber: ae. · View Herald TranscriptAug 17 2019, 1:12 PM

vmaffione edited the test plan for this revision. (Show Details)Aug 17 2019, 1:19 PM

vmaffione added a reviewer: markj.

markj accepted this revision.Aug 19 2019, 4:14 PM

markj added inline comments.

sys/net/if_tuntap.c
113	I would just rename to TUN_UNUSED1, or remove it outright.

This revision is now accepted and ready to land.Aug 19 2019, 4:14 PM

kevans added inline comments.Aug 19 2019, 5:09 PM

sys/net/if_tuntap.c
113	+1 for remove it

vmaffione marked an inline comment as done.Aug 19 2019, 5:14 PM

vmaffione added inline comments.

sys/net/if_tuntap.c
113	Sounds good, I'll do.

vmaffione marked an inline comment as done.Aug 19 2019, 5:22 PM

Closed by commit rS351220: if_tuntap: minor improvements (authored by vmaffione). · Explain WhyAug 19 2019, 5:23 PM

This revision was automatically updated to reflect the committed changes.

vmaffione added a commit: rS351220: if_tuntap: minor improvements.

Herald added a subscriber: imp. · View Herald TranscriptAug 19 2019, 5:23 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

if_tuntap.c

39 lines

Diff 60933

View Options

if_tuntap: minor improvementsClosedPublicActions