Page MenuHomeFreeBSD

if_tuntap: minor improvements
ClosedPublic

Authored by vmaffione on Aug 17 2019, 1:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 2:59 AM
Unknown Object (File)
Sep 6 2023, 9:12 AM
Unknown Object (File)
Sep 6 2023, 9:11 AM
Unknown Object (File)
Sep 6 2023, 9:11 AM
Unknown Object (File)
Sep 1 2023, 7:56 AM
Unknown Object (File)
Jun 25 2023, 12:28 AM
Unknown Object (File)
Jun 25 2023, 12:26 AM
Unknown Object (File)
Jun 25 2023, 12:24 AM
Subscribers

Details

Summary

Rewrite a loop to avoid duplicating the exit condition.
Simplify mask processing in tunpoll().
Fix minor typos.

Test Plan

Tested with a bhyve tap configuration on HEAD.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

vmaffione added a reviewer: markj.
markj added inline comments.
sys/net/if_tuntap.c
113

I would just rename to TUN_UNUSED1, or remove it outright.

This revision is now accepted and ready to land.Aug 19 2019, 4:14 PM
sys/net/if_tuntap.c
113

+1 for remove it

vmaffione added inline comments.
sys/net/if_tuntap.c
113

Sounds good, I'll do.

This revision was automatically updated to reflect the committed changes.