Page MenuHomeFreeBSD

if_tuntap: minor improvements
ClosedPublic

Authored by vmaffione on Aug 17 2019, 1:12 PM.

Details

Summary

Rewrite a loop to avoid duplicating the exit condition.
Simplify mask processing in tunpoll().
Fix minor typos.

Test Plan

Tested with a bhyve tap configuration on HEAD.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vmaffione created this revision.Aug 17 2019, 1:12 PM
vmaffione edited the test plan for this revision. (Show Details)Aug 17 2019, 1:19 PM
vmaffione added a reviewer: markj.
markj accepted this revision.Aug 19 2019, 4:14 PM
markj added inline comments.
sys/net/if_tuntap.c
113 ↗(On Diff #60933)

I would just rename to TUN_UNUSED1, or remove it outright.

This revision is now accepted and ready to land.Aug 19 2019, 4:14 PM
kevans added inline comments.Aug 19 2019, 5:09 PM
sys/net/if_tuntap.c
113 ↗(On Diff #60933)

+1 for remove it

vmaffione marked an inline comment as done.Aug 19 2019, 5:14 PM
vmaffione added inline comments.
sys/net/if_tuntap.c
113 ↗(On Diff #60933)

Sounds good, I'll do.

vmaffione marked an inline comment as done.Aug 19 2019, 5:22 PM
This revision was automatically updated to reflect the committed changes.