Page MenuHomeFreeBSD

Move sc out of the global file

Authored by imp on Aug 12 2019, 5:30 PM.



x86 needs it, as does sparc64. powerpc doesn't use it by default, but some old
powermac notebooks do not work with vt yet for reasons unknonw. Even so, I've
removed it from powerpc LINT. It's not in daily use there, and the intent is to
100% switch to vt now that it works for that platform to limit support burden.

Diff Detail

rS FreeBSD src repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp created this revision.Aug 12 2019, 5:30 PM
jhb added a comment.Aug 12 2019, 5:59 PM

If you wanted to be super crazy you could have a NOTES.syscons file, but that is perhaps over engineering just for syscons. If you did that, I would put the screen savers in it as well and then sparc64 would keep the few 'nodevice foo_saver' it has currently.

64 ↗(On Diff #60684)

Once you do this, this comment isn't quite as meaningful.

64 ↗(On Diff #60684)

Which is to say, I would probably leave this comment out, and maybe combine the changes to move the screen savers with this into a single "syscons" commit.

imp updated this revision to Diff 60686.Aug 12 2019, 6:42 PM

Combine and rebase

jhibbits accepted this revision.Aug 12 2019, 9:02 PM
This revision is now accepted and ready to land.Aug 12 2019, 9:02 PM
jhb accepted this revision.Aug 12 2019, 10:08 PM
jhb added inline comments.
11 ↗(On Diff #60686)

This updated comment probably goes in the first x86/conf/NOTES commit?

This revision was automatically updated to reflect the committed changes.