Page MenuHomeFreeBSD
Differential D21208

Floppy driver really only works on x86
ClosedPublic
Actions

Authored by imp on Aug 10 2019, 4:23 PM.
Tags
None
Referenced Files
F163869291: D21208.id60636.diff
Sun, Jul 26, 6:16 PM
Unknown Object (File)
Fri, Jul 24, 2:13 PM
Unknown Object (File)
Sat, Jul 18, 5:53 AM
Unknown Object (File)
Sat, Jul 18, 4:51 AM
Unknown Object (File)
Thu, Jul 16, 5:48 AM
Unknown Object (File)
Fri, Jul 10, 10:57 AM
Unknown Object (File)
Sun, Jul 5, 7:37 AM
Unknown Object (File)
Fri, Jul 3, 9:14 PM
View All Files
Subscribers
andrew
bdragon
emaste
jhibbits

Details

Reviewers
manu
jhb
jhibbits
emaste
Commits
rS350964: Floppy driver really only works on x86
Summary

Move the floppy driver to the x86 specific notes file.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Aug 10 2019, 4:23 PM
Herald added a reviewer: manu. · View Herald TranscriptAug 10 2019, 4:23 PM
Herald added subscribers: bdragon, jhibbits, emaste, andrew. · View Herald Transcript
Harbormaster completed remote builds in B25776: Diff 60636.Aug 10 2019, 4:23 PM
imp mentioned this in D21203: Start to split out the really x86 specific NOTES from the global notes file. Start with COMPAT_43, since it's really only relevant to x86..Aug 10 2019, 4:23 PM
imp added a reviewer: jhb.
jhibbits accepted this revision.Aug 10 2019, 4:26 PM
This revision is now accepted and ready to land.Aug 10 2019, 4:26 PM
manu accepted this revision.Aug 10 2019, 4:34 PM

Beside my comment LGTM

sys/x86/conf/NOTES
18 ↗(On Diff #60636)

I guess this comment was meant to be in D21207

imp added inline comments.Aug 10 2019, 10:00 PM
sys/x86/conf/NOTES
18 ↗(On Diff #60636)

yes.

jhb accepted this revision.Aug 12 2019, 5:00 PM
emaste accepted this revision.Aug 12 2019, 5:26 PM
Closed by commit rS350964: Floppy driver really only works on x86 (authored by imp). · Explain WhyAug 12 2019, 10:59 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rS350964: Floppy driver really only works on x86.

Revision Contents
Changeset List

PathSize
head/
sys/
arm/
conf/
1 line
arm64/
conf/
3 lines
conf/
26 lines
powerpc/
conf/
1 line
sparc64/
conf/
2 lines
x86/
conf/
25 lines

Diff 60702

View Options

head/sys/arm/conf/NOTES

Loading...
View Options

head/sys/arm64/conf/NOTES

Loading...
View Options

head/sys/conf/NOTES

Loading...
View Options

head/sys/powerpc/conf/NOTES

Loading...
View Options

head/sys/sparc64/conf/NOTES

Loading...
View Options

head/sys/x86/conf/NOTES

Loading...