Page MenuHomeFreeBSD

Handle concurrent pmap_kextract() and promotion/demotion on arm64
ClosedPublic

Authored by alc on Tue, Aug 6, 3:15 PM.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alc created this revision.Tue, Aug 6, 3:15 PM
andrew accepted this revision.Wed, Aug 7, 10:20 AM
andrew added inline comments.
arm64/arm64/pmap.c
1134 ↗(On Diff #60507)

This else is unneeded as the if will return.

This revision is now accepted and ready to land.Wed, Aug 7, 10:20 AM
alc updated this revision to Diff 60545.Wed, Aug 7, 4:09 PM

Deindent most of pmap_kextract().

Revise the comment in pmap_kextract() to refer to pmap_update_entry() rather than demotion and promotion because we also use pmap_update_entry() on L3 entries in pmap_change_attr_locked().

This revision now requires review to proceed.Wed, Aug 7, 4:09 PM
alc marked an inline comment as done.Wed, Aug 7, 4:10 PM
markj accepted this revision.Wed, Aug 7, 4:11 PM
This revision is now accepted and ready to land.Wed, Aug 7, 4:11 PM
andrew accepted this revision.Wed, Aug 7, 4:22 PM