Page MenuHomeFreeBSD
Differential D21072

Remove support for kernel.tramp and kernel.tramp.gz
ClosedPublic
Actions

Authored by imp on Jul 26 2019, 4:50 AM.
Tags
None
Referenced Files
F81528913: D21072.diff
Wed, Apr 17, 2:48 PM
Unknown Object (File)
Wed, Apr 10, 12:34 AM
Unknown Object (File)
Tue, Apr 2, 2:01 AM
Unknown Object (File)
Feb 16 2024, 4:35 AM
Unknown Object (File)
Feb 16 2024, 4:35 AM
Unknown Object (File)
Feb 16 2024, 4:35 AM
Unknown Object (File)
Feb 16 2024, 4:35 AM
Unknown Object (File)
Feb 16 2024, 4:19 AM
View All 53 Files
Subscribers
andrew
delphij
ota_j.email.ne.jp
yamori813_yahoo.co.jp

Details

Reviewers
gonzo
• ian
Commits
rS350377: Remove support for kernel.tramp and kernel.tramp.gz
Summary

Nothing uses these anymore. They were for super small armv4 boards. Today, all
armv5 kernels boot via uboot which has its own compression scheme.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25532
Build 24147: arc lint + arc unit

Event Timeline

imp created this revision.Jul 26 2019, 4:50 AM
Herald added a subscriber: andrew. · View Herald TranscriptJul 26 2019, 4:50 AM
Harbormaster completed remote builds in B25512: Diff 60158.Jul 26 2019, 4:50 AM
imp added reviewers: gonzo, • ian.Jul 26 2019, 4:52 AM
delphij added a subscriber: delphij.Jul 26 2019, 7:32 AM
delphij added inline comments.
sys/conf/Makefile.arm
128

Maybe unifdef -UKZIP and have elf_trampoline.c changed too?

andrew added inline comments.Jul 26 2019, 8:49 AM
sys/conf/Makefile.arm
128

elf_trampoline.c should just be removed. With this change it will no longer be built.

• ian added inline comments.Jul 26 2019, 2:57 PM
sys/conf/Makefile.arm
90–91

This reference to KERNPHYSADDR can go too, it doesn't show up in ldscript.arm so the subsitution is a no-op here. The subsitution for KERNVIRTADDR is still vaild though.

ota_j.email.ne.jp added a subscriber: ota_j.email.ne.jp.Jul 26 2019, 10:37 PM
yamori813_yahoo.co.jp added a subscriber: yamori813_yahoo.co.jp.Jul 26 2019, 11:29 PM

I agree this change.

gonzo accepted this revision.Jul 26 2019, 11:34 PM

No objections

This revision is now accepted and ready to land.Jul 26 2019, 11:34 PM
ota_j.email.ne.jp added inline comments.Jul 27 2019, 12:24 AM
sys/conf/Makefile.arm
128

It looks sys/arm/arm/inckern.S is also no longer used with this removal.

imp updated this revision to Diff 60185.Jul 27 2019, 5:43 AM

Update per reviews

This revision now requires review to proceed.Jul 27 2019, 5:43 AM
Harbormaster completed remote builds in B25532: Diff 60185.Jul 27 2019, 5:43 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 27 2019, 5:24 PM
Closed by commit rS350377: Remove support for kernel.tramp and kernel.tramp.gz (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rS350377: Remove support for kernel.tramp and kernel.tramp.gz.
ota_j.email.ne.jp mentioned this in D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..Jul 28 2019, 8:20 PM

Revision Contents
Changeset List

PathSize
sys/
arm/
arm/
conf/
1 line
mv/
discovery/
1 line
orion/
1 line
1 line
ralink/
1 line
conf/
83 lines

Diff 60185

View Options

sys/arm/arm/inckern.S

Loading...
View Options

sys/arm/conf/NOTES.armv5

Loading...
View Options

sys/arm/mv/discovery/std.db78xxx

Loading...
View Options

sys/arm/mv/orion/std.db88f5xxx

Loading...
View Options

sys/arm/mv/orion/std.ts7800

Loading...
View Options

sys/arm/ralink/std.ralink

Loading...
View Options

sys/conf/Makefile.arm

Loading...