Page MenuHomeFreeBSD

Remove support for kernel.tramp and kernel.tramp.gz
ClosedPublic

Authored by imp on Jul 26 2019, 4:50 AM.

Details

Summary

Nothing uses these anymore. They were for super small armv4 boards. Today, all
armv5 kernels boot via uboot which has its own compression scheme.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp created this revision.Jul 26 2019, 4:50 AM
imp added reviewers: gonzo, ian.Jul 26 2019, 4:52 AM
delphij added inline comments.
sys/conf/Makefile.arm
128 ↗(On Diff #60158)

Maybe unifdef -UKZIP and have elf_trampoline.c changed too?

andrew added inline comments.Jul 26 2019, 8:49 AM
sys/conf/Makefile.arm
128 ↗(On Diff #60158)

elf_trampoline.c should just be removed. With this change it will no longer be built.

ian added inline comments.Jul 26 2019, 2:57 PM
sys/conf/Makefile.arm
91 ↗(On Diff #60158)

This reference to KERNPHYSADDR can go too, it doesn't show up in ldscript.arm so the subsitution is a no-op here. The subsitution for KERNVIRTADDR is still vaild though.

gonzo accepted this revision.Jul 26 2019, 11:34 PM

No objections

This revision is now accepted and ready to land.Jul 26 2019, 11:34 PM
sys/conf/Makefile.arm
128 ↗(On Diff #60158)

It looks sys/arm/arm/inckern.S is also no longer used with this removal.

imp updated this revision to Diff 60185.Jul 27 2019, 5:43 AM

Update per reviews

This revision now requires review to proceed.Jul 27 2019, 5:43 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 27 2019, 5:24 PM
This revision was automatically updated to reflect the committed changes.