Page MenuHomeFreeBSD
Differential D21044

Add c++14 to COMPILER_FEATURES
ClosedPublic
Actions

Authored by asomers on Jul 23 2019, 11:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 18, 2:59 AM
Unknown Object (File)
Fri, Oct 17, 4:41 PM
Unknown Object (File)
Fri, Oct 17, 4:41 PM
Unknown Object (File)
Fri, Oct 17, 4:41 PM
Unknown Object (File)
Fri, Oct 17, 4:41 PM
Unknown Object (File)
Fri, Oct 17, 8:10 AM
Unknown Object (File)
Tue, Oct 14, 12:35 AM
Unknown Object (File)
Mon, Oct 13, 11:25 AM
View All Files
Subscribers
emaste
imp
kib

Details

Reviewers
ngie
bdrewery
kib
emaste
Commits
rS351949: MFC r350291:
rS350291: Add c++14 and c++17 to COMPILER_FEATURES
Summary

Add c++14 to COMPILER_FEATURES

This will be used to gate the fusefs tests. It's a partial merge of r348281
from projects/fuse2.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25495
Build 24114: arc lint + arc unit

Event Timeline

asomers created this revision.Jul 23 2019, 11:06 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 23 2019, 11:06 PM
Harbormaster completed remote builds in B25477: Diff 60068.Jul 23 2019, 11:07 PM
asomers mentioned this in D20940: fusefs: merge from projects/fuse2.Jul 23 2019, 11:15 PM
kib added a subscriber: kib.Jul 24 2019, 9:38 AM

Add c++17 while there ?

share/mk/bsd.compiler.mk
205

Are you claiming that arbitrary version of clang++ supports enough of c++14 ?

asomers added a comment.Jul 24 2019, 1:40 PM
In D21044#456814, @kib wrote:

Add c++17 while there ?

I have no immediate need for c++17. But I could add it if you like.

share/mk/bsd.compiler.mk
205

Every version of clang that's in the base and in ports, yes.

asomers updated this revision to Diff 60091.Jul 24 2019, 1:56 PM

Qualify clang's c++11 and c++14 support, add a c++17 feature, and sort features by version.

Harbormaster completed remote builds in B25494: Diff 60091.Jul 24 2019, 1:56 PM
kib added inline comments.Jul 24 2019, 2:09 PM
share/mk/bsd.compiler.mk
213

Don't you need () around && expression, same as it is done on the next line ?

asomers added inline comments.Jul 24 2019, 2:12 PM
share/mk/bsd.compiler.mk
213

Technically no, because && has higher precedence than ||.

emaste added inline comments.Jul 24 2019, 2:43 PM
share/mk/bsd.compiler.mk
213

Probably worth adding them for consistency (between the clang and gcc conditionals) though?

asomers updated this revision to Diff 60092.Jul 24 2019, 2:48 PM

More consistent style

Harbormaster completed remote builds in B25495: Diff 60092.Jul 24 2019, 2:48 PM
kib accepted this revision.Jul 24 2019, 3:04 PM
This revision is now accepted and ready to land.Jul 24 2019, 3:04 PM
emaste accepted this revision.Jul 24 2019, 3:08 PM
Closed by commit rS350291: Add c++14 and c++17 to COMPILER_FEATURES (authored by asomers). · Explain WhyJul 24 2019, 3:10 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rS350291: Add c++14 and c++17 to COMPILER_FEATURES.
asomers added a commit: rS351949: MFC r350291:.Sep 6 2019, 6:23 PM

Revision Contents
Changeset List

PathSize
share/
mk/
12 lines

Diff 60092

View Options

share/mk/bsd.compiler.mk

Loading...