Add mkostempsat(3).
ClosedPublic
Actions

Authored by markj on Jul 22 2019, 8:30 PM.

Details

Reviewers

brooks
oshogbo
emaste
cem

Group Reviewers

capsicum
manpages

Commits

rS350420: Add mkostempsat(3).

Summary

This is a variant of mkostemps() which takes a directory descriptor and
returns a descriptor for a file relative to that directory. This allows
easier capsicumization of some applications.

My particular use-case is strip(1), which processes each of its input
files, storing the result in a tempfile, and renames each tempfile back
over the corresponding input file.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jul 22 2019, 8:30 PM

Harbormaster completed remote builds in B25461: Diff 60032.Jul 22 2019, 8:30 PM

markj edited the summary of this revision. (Show Details)Jul 22 2019, 8:31 PM

markj added reviewers: brooks, oshogbo, emaste, capsicum.

brooks added inline comments.Jul 22 2019, 10:23 PM

lib/libc/stdio/mktemp.c
163 ↗	(On Diff #60032)	Does there need to be a AT_FDCWD case here to match the manpage?

LGTM other than the issue brooks noticed.

lib/libc/stdio/mktemp.c
163 ↗	(On Diff #60032)	Yes, I think so.

Use AT_FDCWD when no relative dfd is specified.
Add a man page mlink.

Harbormaster completed remote builds in B25464: Diff 60036.Jul 23 2019, 1:53 AM

markj marked 2 inline comments as done.Jul 23 2019, 1:53 AM

markj added inline comments.

lib/libc/stdio/mktemp.c
163 ↗	(On Diff #60032)	The new block isn't really needed at all. The non-"at" mktemp functions can specify AT_FDCWD as the directory fd, which lets me get rid of the branches that I had added.