Page MenuHomeFreeBSD

Fix two mismatches between function declaration and definition.
ClosedPublic

Authored by brooks on Jul 15 2019, 10:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 4 2025, 12:09 AM
Unknown Object (File)
Aug 10 2025, 7:19 AM
Unknown Object (File)
Jul 27 2025, 10:49 PM
Unknown Object (File)
Jul 19 2025, 9:21 PM
Unknown Object (File)
Jul 17 2025, 4:16 PM
Unknown Object (File)
Jul 9 2025, 10:09 AM
Unknown Object (File)
Jun 10 2025, 12:39 AM
Unknown Object (File)
May 28 2025, 7:04 PM
Subscribers

Details

Summary

In both cases, function pointer arguments were inconsistently declared
and the result worked because of C's odd rules around function pointer
(de)references. With a stricter compiler these fail to compile.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

While we should probably just do in amd, these are easy fixes and there's no upstream conflicts to worry about (last am-utils release in 2014 and their git server don't seem to host a repo.

I'd just drop the extra * on the other of the definition/declaration, but I don't know if we have a style(9) preference. Functionally / semantically it looks good.

This revision is now accepted and ready to land.Jul 15 2019, 10:49 PM
brooks retitled this revision from Fix two mismatches between function decleration and definition. to Fix two mismatches between function declaration and definition..Jul 16 2019, 4:02 PM