Page MenuHomeFreeBSD

Fix two mismatches between function declaration and definition.
ClosedPublic

Authored by brooks on Jul 15 2019, 10:44 PM.

Details

Summary

In both cases, function pointer arguments were inconsistently declared
and the result worked because of C's odd rules around function pointer
(de)references. With a stricter compiler these fail to compile.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

brooks created this revision.Jul 15 2019, 10:44 PM

While we should probably just do in amd, these are easy fixes and there's no upstream conflicts to worry about (last am-utils release in 2014 and their git server don't seem to host a repo.

cem accepted this revision.Jul 15 2019, 10:49 PM

I'd just drop the extra * on the other of the definition/declaration, but I don't know if we have a style(9) preference. Functionally / semantically it looks good.

This revision is now accepted and ready to land.Jul 15 2019, 10:49 PM
brooks retitled this revision from Fix two mismatches between function decleration and definition. to Fix two mismatches between function declaration and definition..Jul 16 2019, 4:02 PM
This revision was automatically updated to reflect the committed changes.