remove gotos from vm_map_unwire

[dougm]

Summary

Move an assignment, drop a label, and change gotos to break statements in vm_map_unwire. The code generated on amd86 is unchanged.

[alc]

I don't like this change. In cases like this, specifically error handling in complex code, the goto is easier to understand (and very common in kernel code). A "break;" is context sensitive, i.e., I have to determine whether I am a nested loop.

[dougm]

Mentors, what do you want me to do here?

[markj]

In D20850#451779, @dougm wrote:

Mentors, what do you want me to do here?

Typically, when there is some kind of dispute over a change, it is appropriate to revert the change pending some discussion, especially if the dispute is with a maintainer of the code in question. If you feel strongly that the change should be kept, it would be reasonable to continue that discussion here following a revert.

[alc]

I don't feel strongly enough about this issue to request that the change be reverted.