Differential D20850

remove gotos from vm_map_unwire
ClosedPublic
Actions

Authored by dougm on Jul 4 2019, 6:15 AM.

Tags

None

Referenced Files

	F132920632: D20850.id59410.diff
	Tue, Oct 21, 5:02 AM

	F132920629: D20850.id59384.diff
	Tue, Oct 21, 5:02 AM

	F132920617: D20850.id59411.diff
	Tue, Oct 21, 5:02 AM

	F132920607: D20850.id.diff
	Tue, Oct 21, 5:02 AM

	Unknown Object (File)
	Mon, Oct 20, 6:37 PM

	Unknown Object (File)
	Wed, Oct 15, 6:08 AM

	Unknown Object (File)
	Sat, Oct 11, 7:46 PM

	Unknown Object (File)
	Wed, Sep 24, 1:54 AM

View All 88 Files

Subscribers

Details

Reviewers

alc
markj
kib

Commits

rS349745: Move an assignment, drop a label, and change gotos to break statements

Summary

Move an assignment, drop a label, and change gotos to break statements in vm_map_unwire. The code generated on amd86 is unchanged.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm created this revision.Jul 4 2019, 6:15 AM

dougm updated this revision to Diff 59410.Jul 4 2019, 7:21 PM

dougm added a reviewer: markj.

markj accepted this revision.Jul 4 2019, 7:24 PM

This revision is now accepted and ready to land.Jul 4 2019, 7:24 PM

Closed by commit rS349745: Move an assignment, drop a label, and change gotos to break statements (authored by dougm). · Explain WhyJul 4 2019, 7:25 PM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rS349745: Move an assignment, drop a label, and change gotos to break statements.

Herald added a subscriber: imp. · View Herald TranscriptJul 4 2019, 7:25 PM

I don't like this change. In cases like this, specifically error handling in complex code, the goto is easier to understand (and very common in kernel code). A "break;" is context sensitive, i.e., I have to determine whether I am a nested loop.

Mentors, what do you want me to do here?

In D20850#451779, @dougm wrote:

Mentors, what do you want me to do here?

Typically, when there is some kind of dispute over a change, it is appropriate to revert the change pending some discussion, especially if the dispute is with a maintainer of the code in question. If you feel strongly that the change should be kept, it would be reasonable to continue that discussion here following a revert.

I don't feel strongly enough about this issue to request that the change be reverted.

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

9 lines

Diff 59411

head/sys/vm/vm_map.c

Loading...