Page MenuHomeFreeBSD

remove gotos from vm_map_unwire
ClosedPublic

Authored by dougm on Jul 4 2019, 6:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 6:08 AM
Unknown Object (File)
Sat, Oct 11, 7:46 PM
Unknown Object (File)
Wed, Sep 24, 1:54 AM
Unknown Object (File)
Mon, Sep 22, 3:10 AM
Unknown Object (File)
Sun, Sep 21, 7:18 AM
Unknown Object (File)
Sun, Sep 21, 3:33 AM
Unknown Object (File)
Sun, Sep 21, 12:04 AM
Unknown Object (File)
Sat, Sep 20, 10:17 PM
Subscribers

Details

Summary

Move an assignment, drop a label, and change gotos to break statements in vm_map_unwire. The code generated on amd86 is unchanged.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jul 4 2019, 7:24 PM

I don't like this change. In cases like this, specifically error handling in complex code, the goto is easier to understand (and very common in kernel code). A "break;" is context sensitive, i.e., I have to determine whether I am a nested loop.

Mentors, what do you want me to do here?

Mentors, what do you want me to do here?

Typically, when there is some kind of dispute over a change, it is appropriate to revert the change pending some discussion, especially if the dispute is with a maintainer of the code in question. If you feel strongly that the change should be kept, it would be reasonable to continue that discussion here following a revert.

I don't feel strongly enough about this issue to request that the change be reverted.