audio/libcanberra: add Mk/Uses/canberra.mk, modularize plugins/integrations

[val_packett.cool]

Summary

The libcanberra port was not in a good state… :)

@tcberner initially wanted to depend on libcanberra-pulse in KDE Plasma 5.
I want to get rid of gtk2 dependencies as much as possible, and libcanberra-gtk was forcing gtk2 onto a lot of systems unnecessarily.

With this update,

• libcanberra-gtk2 and libcanberra-gtk3 integrations are in separate packages
• libcanberra-gtk2 is only depended on when actually used in the port
• header and vapi for gtk (which is used by any of the gtk 2/3) are in the main package, so there's no "require 2 if using 3" or vice versa situation
  • well "require 3 if using 2" would kinda be acceptable, but that would be harder to do with the Uses/canberra.mk code
• libcanberra-pulse and libcanberra-gstreamer backends are in separate packages
• libcanberra-pulse actually will be used if installed
• the dependency on canberra is written with USES
• the canberra dependency is dropped from up-to-date gnome ports (e.g. some games) that have switched to only using the gsound API
• libudev won't be picked up when building outside of poudriere (it's useless here for us, the calls are for alsa soundcards I think)

References:

• https://fedora.pkgs.org/33/fedora-aarch64/libcanberra-gtk2-0.30-23.fc33.aarch64.rpm.html / https://fedora.pkgs.org/33/fedora-aarch64/libcanberra-gtk3-0.30-23.fc33.aarch64.rpm.html (gnome-settings-daemon-3.0/gtk-modules/canberra-gtk-module.desktop installed in the gtk3 one)
• https://www.archlinux.org/packages/extra/x86_64/libcanberra/ (gdm/autostart etc. not installed at all)

[tcberner]

See also D20828 .

[tcberner]

As discussed with @swills

TODO:

• create -gtk2 slave
• create USES=canberra or some other magic

[tcberner]

Create canberra.mk and convert tree to use it.

• maybe add canberra-gtk-header port?

[kwm]

audio/libcanberra/pkg-plist

1

How about also putting canberra-gtk.h in this plist like the current port does?

sysutils/mate-control-center/Makefile

28

Just picking a random spot. This (and others like it) don't seem right. Mate uses gtk30 so it seems gtk2 isn't needed. The reason why both libcanberra-gtk and libcanberra-gtk3 are listed is because the gtk3 depended on the -gtk port and because the stage-qa script was reporting a missing dependany.

[tcberner]

The alternative would be to have a port that simply installes the shared gtk header.

[bapt]

at quick glance It looks like it should more be a bunch of flavors than slave ports, am I missing something?

[val_packett.cool]

Way too many things have :gtk2 here, no gtk3 apps should need it

audio/pavucontrol/Makefile

18

pavucontrol does not need gtk2

deskutils/gnome-screenshot/Makefile

21

Why would this need gtk2?

mail/geary/Makefile

30 ↗

(On Diff #59321)

This is a gtk3 app

[tcberner]

In D20830#614158, @greg_unrelenting.technology wrote:

Way too many things have :gtk2 here, no gtk3 apps should need it

would you mind commandeering this and finishing it?

[val_packett.cool]

oof. Hopefully this is good now, I haven't tested everything, but lots of things build fine without gtk2 now.

[val_packett.cool]

devel/kf5-knotifications/Makefile

28

@tcberner hopefully this kde cmake stuff is all correct, I haven't tested with these options OFF

[val_packett.cool]

Uploading the current rebase since @adridg pinged on bugzilla.

Again, I have not tested every affected port, so this does need better testing…

[val_packett.cool]

rebase: gdm

[tcberner]

Thanks, I will take a look.

[tcberner]

Mk/Uses/canberra.mk

63

^ double - in canberra--${component}_TYPE+=