Page MenuHomeFreeBSD

audio/libcanberra: remove options, create slave ports, add Mk/Uses/canberra.mk
Needs ReviewPublic

Authored by tcberner on Jul 1 2019, 8:45 PM.

Details

Reviewers
kwm
swills
Group Reviewers
gnome
kde
O5: Ports Framework(Owns No Changed Paths)
portmgr
Summary

For Plasma5's notification we should have an easy way to depend on libcanberra-pulse.
This is not easily possible at the moment as PULSE is a non-default (and *broken*)
optin in audio/libcanberra.

This patch splits the options out into further slave ports
audio/libcanberra-pulse and audio/libcanberra-gstreamer.

It also touches up the existing ports a bit.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25182
Build 23869: arc lint + arc unit

Event Timeline

tcberner created this revision.Jul 1 2019, 8:45 PM

As discussed with @swills

TODO:

  • create -gtk2 slave
  • create USES=canberra or some other magic
tcberner updated this revision to Diff 59321.EditedJul 2 2019, 6:10 PM

Create canberra.mk and convert tree to use it.

  • maybe add canberra-gtk-header port?
tcberner retitled this revision from audio/libcanberra: remove options, create slave ports to audio/libcanberra: remove options, create slave ports, add Mk/Uses/canberra.mk.Jul 2 2019, 6:11 PM
kwm added inline comments.Jul 6 2019, 5:52 AM
audio/libcanberra/pkg-plist
1

How about also putting canberra-gtk.h in this plist like the current port does?

sysutils/mate-control-center/Makefile
28

Just picking a random spot. This (and others like it) don't seem right. Mate uses gtk30 so it seems gtk2 isn't needed. The reason why both libcanberra-gtk and libcanberra-gtk3 are listed is because the gtk3 depended on the -gtk port and because the stage-qa script was reporting a missing dependany.

The alternative would be to have a port that simply installes the shared gtk header.