|453 ↗||(On Diff #59182)|
Both valid points. But minidumpsys already has a %llu printf with (long long)dumpsize >> 20 and I thought it better to stay consistent with existing code.
Anyway, do as you want. Printing any estimation of the size in case of failure is an improvement on its own, even if not perfect.
|345 ↗||(On Diff #59182)|
If you look closer, the formats usage is not consistent, one case uses %llu, another %ju. You may fix %llu case while there.