Page MenuHomeFreeBSD
Differential D20789

Use DEVICE memory instead of UNCACHEABLE on aarch64 in LinuxKPI ioremap
ClosedPublic
Actions

Authored by • hselasky on Jun 28 2019, 12:31 AM.
Tags
Referenced Files
Unknown Object (File)
Mon, Nov 18, 1:45 AM
Unknown Object (File)
Tue, Nov 5, 9:33 PM
Unknown Object (File)
Thu, Oct 31, 6:46 AM
Unknown Object (File)
Thu, Oct 31, 6:45 AM
Unknown Object (File)
Thu, Oct 31, 6:45 AM
Unknown Object (File)
Thu, Oct 31, 6:45 AM
Unknown Object (File)
Thu, Oct 31, 6:44 AM
Unknown Object (File)
Thu, Oct 31, 6:44 AM
View All 91 Files
Subscribers
emaste
imp
zeising

Details

Reviewers
val_packett.cool
• hselasky
Group Reviewers
Contributor Reviews (src)
arm64
Commits
rS352330: MFC r351693:
rS352328: MFC r351693:
rS351693: Use DEVICE memory instead of UNCACHEABLE on aarch64 in ioremap() in the…
Summary

This fixes system hangs on reading device registers in LinuxKPI drivers on aarch64.

VM_MEMATTR_DEVICE is also defined on RISC-V and 32-bit ARM, so I used ifdef VM_MEMATTR_DEVICE to make sure anyone trying to port LinuxKPI stuff to these architectures doesn't hit the same problem.

Test Plan

Tested on: Marvell MACCHIATObin (Armada8k) + mlx4en, amdgpu

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

val_packett.cool created this revision.Jun 28 2019, 12:31 AM
Herald added subscribers: emaste, imp. · View Herald TranscriptJun 28 2019, 12:31 AM
• hselasky added inline comments.Jun 28 2019, 8:48 AM
sys/compat/linuxkpi/common/include/linux/io.h
368 ↗(On Diff #59141)

Can you use /**/ comment here instead of // ?

What about the other ioremap() functions?

val_packett.cool updated this revision to Diff 59154.Jun 28 2019, 1:50 PM

hm, just looked at linux — regular, _nocache and _wt are all PROT_DEVICE_nGnRE. Let's change them all then.

• hselasky accepted this revision.Jun 28 2019, 1:56 PM

Spell lkpi -> LinuxKPI in the commit message.

Looks OK.

This revision is now accepted and ready to land.Jun 28 2019, 1:56 PM
val_packett.cool edited the summary of this revision. (Show Details)Jun 29 2019, 11:33 AM
val_packett.cool edited the test plan for this revision. (Show Details)
val_packett.cool added a comment.Jul 8 2019, 10:34 PM

please commit?

• hselasky added a comment.Jul 12 2019, 3:29 PM

Please stay tuned!

zeising added a subscriber: zeising.Jul 17 2019, 6:17 PM
val_packett.cool added a comment.Aug 27 2019, 9:13 PM

ping

• hselasky added a comment.Aug 28 2019, 7:27 AM

Pong :-) I'll have a look at the patch again.

• hselasky commandeered this revision.Aug 28 2019, 8:14 AM
• hselasky edited reviewers, added: val_packett.cool; removed: • hselasky.
This revision now requires review to proceed.Aug 28 2019, 8:14 AM
• hselasky updated this revision to Diff 61392.Aug 28 2019, 8:15 AM

Can you test this patch?

Harbormaster completed remote builds in B26154: Diff 61392.Aug 28 2019, 8:15 AM
• hselasky accepted this revision.Aug 28 2019, 8:16 AM
This revision is now accepted and ready to land.Aug 28 2019, 8:16 AM
val_packett.cool added a comment.Aug 28 2019, 6:21 PM

panic: vm_fault_hold: fault on nofault entry, addr: 0xffff00006e1ff000 in gfx_v8_0_kiq_resume

so no, looks like wc/wb are not meant to be device memory

• hselasky added a comment.Aug 28 2019, 7:28 PM

Can you update my patch and test an again? Thank you!

val_packett.cool added a comment.Aug 28 2019, 11:03 PM
In D20789#467032, @hselasky wrote:

Can you update my patch and test an again? Thank you!

https://reviews.freebsd.org/differential/diff/61437/ is what I edited it to. Looks like I'm not allowed to update this revision after you took it.

• hselasky added a comment.Aug 29 2019, 7:12 AM

Just select commander revision in the action menu.

• hselasky updated this revision to Diff 61437.Aug 29 2019, 7:13 AM
This revision now requires review to proceed.Aug 29 2019, 7:13 AM
Harbormaster completed remote builds in B26174: Diff 61437.Aug 29 2019, 7:13 AM
• hselasky accepted this revision.Aug 29 2019, 7:13 AM
This revision is now accepted and ready to land.Aug 29 2019, 7:13 AM
• hselasky added a comment.Aug 30 2019, 11:32 AM

I'll try to get the patch in on Monday. I'm currently busy. Thank you for the patience.

Closed by commit rS351693: Use DEVICE memory instead of UNCACHEABLE on aarch64 in ioremap() in the… (authored by • hselasky). · Explain WhySep 2 2019, 8:34 AM
This revision was automatically updated to reflect the committed changes.
• hselasky added a commit: rS351693: Use DEVICE memory instead of UNCACHEABLE on aarch64 in ioremap() in the….
• hselasky added a commit: rS352328: MFC r351693:.Sep 14 2019, 1:33 PM
• hselasky added a commit: rS352330: MFC r351693:.

Revision Contents
Changeset List

PathSize
head/
sys/
compat/
linuxkpi/
common/
include/
linux/
17 lines

Diff 61546

View Options

head/sys/compat/linuxkpi/common/include/linux/io.h

Loading...