Page MenuHomeFreeBSD
Differential D20751

vm_map_protect(9) fails to document KERN_RESOURCE_SHORTAGE return value.
ClosedPublic
Actions

Authored by dougm on Jun 25 2019, 6:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 22, 11:42 PM
Unknown Object (File)
Mon, Oct 20, 11:32 PM
Unknown Object (File)
Wed, Oct 15, 2:33 AM
Unknown Object (File)
Tue, Oct 14, 3:59 AM
Unknown Object (File)
Sat, Oct 11, 6:02 PM
Unknown Object (File)
Sat, Oct 11, 5:40 PM
Unknown Object (File)
Sat, Oct 11, 12:59 PM
Unknown Object (File)
Sat, Oct 11, 12:59 PM
View All Files
Subscribers
alc
imp

Details

Reviewers
kib
markj
Group Reviewers
manpages
Commits
rS349379: Document the KERN_PROTECTION_FAILURE return value from vm_map_protect().
Summary

This patch is a meager attempt to correct that.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm created this revision.Jun 25 2019, 6:31 AM
dougm added a subscriber: alc.Jun 25 2019, 6:47 AM
alc added inline comments.Jun 25 2019, 7:17 AM
vm_map_protect.9
99

The range isn't being allocated. It is copy-on-write, and it is transitioning from read-only to read/write.

dougm updated this revision to Diff 58983.Jun 25 2019, 7:24 AM

Take Alan's suggestion.

kib added inline comments.Jun 25 2019, 10:33 AM
vm_map_protect.9
100

I think it is somewhat too cryptic. 'If copy-on-write mapping is transitioned from ro to rw, too little swap space is available for backing the copied pages'.

dougm updated this revision to Diff 59005.Jun 25 2019, 3:37 PM

Accept Kostik's suggestion.

dougm updated this revision to Diff 59006.Jun 25 2019, 3:40 PM
markj accepted this revision.Jun 25 2019, 4:41 PM
markj added inline comments.
vm_map_protect.9
99

"If a copy-on-write mapping is transitioned from read-only to read-write..."

This revision is now accepted and ready to land.Jun 25 2019, 4:41 PM
kib accepted this revision.Jun 25 2019, 4:46 PM

With Mark' note, accepted.

dougm updated this revision to Diff 59016.Jun 25 2019, 4:47 PM

Accept reviewer suggestion.

This revision now requires review to proceed.Jun 25 2019, 4:47 PM
markj added inline comments.Jun 25 2019, 4:49 PM
vm_map_protect.9
99

Still missing an article: "If a copy-on-write..."

dougm updated this revision to Diff 59017.Jun 25 2019, 4:51 PM

Articulate.

markj accepted this revision.Jun 25 2019, 5:15 PM
This revision is now accepted and ready to land.Jun 25 2019, 5:15 PM
Closed by commit rS349379: Document the KERN_PROTECTION_FAILURE return value from vm_map_protect(). (authored by dougm). · Explain WhyJun 25 2019, 5:27 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rS349379: Document the KERN_PROTECTION_FAILURE return value from vm_map_protect()..
Herald added a reviewer: manpages. · View Herald TranscriptJun 25 2019, 5:27 PM
Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

PathSize
4 lines

Diff 59006

View Options

vm_map_protect.9

Loading...