Paths

Table of Contentst

Differential D20695

Fix VOP_PUTPAGES(9) in regards to the use of VM_PAGER_CLUSTER_OK
ClosedPublic
Actions

Authored by khng on Jun 19 2019, 8:04 AM.

Details

Reviewers

emaste
mckusick

Group Reviewers

manpages

Commits

rS350165: MFC r349543
rS349543: Fix VOP_PUTPAGES(9) in regards to the use of VM_PAGER_CLUSTER_OK

Summary

By reading the implementation of vnode_pager_putpages_ioflags() and
vnode_pager_generic_putpages(), if VM_PAGER_CLUSTER_OK is not set write
may be performed asynchronously.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

khng created this revision.Jun 19 2019, 8:04 AM

Harbormaster completed remote builds in B24930: Diff 58784.Jun 19 2019, 8:04 AM

Fix commit message

Harbormaster completed remote builds in B24931: Diff 58785.Jun 19 2019, 8:09 AM

lwhsu added reviewers: emaste, mckusick.Jun 26 2019, 5:02 PM

Doing asynchronous writes prevents clustering. The correct fix is to say:

If
.Dv VM_PAGER_CLUSTER_OK
is set, writes may be delayed so that related writes
can be coalesced for efficiency, e.g.,

This revision now requires changes to proceed.Jun 27 2019, 9:09 PM

Updated according to @mckusick 's suggestion

Harbormaster completed remote builds in B25102: Diff 59147.Jun 28 2019, 4:57 AM

Looks good to go.

This revision is now accepted and ready to land.Jun 29 2019, 2:49 AM

I'll take care of this and also bump the .Dd field.

Closed by commit rS349543: Fix VOP_PUTPAGES(9) in regards to the use of VM_PAGER_CLUSTER_OK (authored by lwhsu). · Explain WhyJun 29 2019, 2:56 PM

This revision was automatically updated to reflect the committed changes.

lwhsu added a commit: rS349543: Fix VOP_PUTPAGES(9) in regards to the use of VM_PAGER_CLUSTER_OK.

Herald added a subscriber: imp. · View Herald TranscriptJun 29 2019, 2:56 PM

lwhsu added a commit: rS350165: MFC r349543.Jul 20 2019, 8:40 AM

Revision Contents
Changeset List

Path

Size

head/

share/

man/

man9/

VOP_GETPAGES.9

4 lines

Diff 59195

View Options

head/share/man/man9/VOP_GETPAGES.9

Fix VOP_PUTPAGES(9) in regards to the use of VM_PAGER_CLUSTER_OKClosedPublicActions