[new port] devel/appmenu-gtk-module: GTK+ application menu modules

[arrowd]

Summary

Integrates applications using the older GtkMenuShell and GtkMenuItem APIs with the desktop environment's global menu bar.

[mat]

Please use flavors.

[landonf]

Adopt FLAVORS, replacing the use of slave ports.

Additionally, fixed two small issues:

• Add WWW line to pkg-descr
• Include missing --no-same-(owner|permissions) in EXTRACT_AFTER_ARGS.

[mat]

devel/appmenu-gtk-module/Makefile

8

Please use flavor helpers.

22

This should be in the .if below.

33

After this line, you do not need to do ${FLAVOR:U}, using ${FLAVOR} is enough.

54

Please use flavor helpers.

[landonf]

Incorporate review feedback:

• Use flavor helpers
• Do not specify LICENSE for the meta port
• Drop use of :U where unnecessary.

[mat]

devel/appmenu-gtk-module/Makefile

11–19

Please symplify this, no need for all those if's, soemthing like:

COMMENT=  ${COMMENT_${FLAVOR}}
COMMENT_meta=  GTK+ modules to display old-style menus in the global menu bar
COMMENT_common= ...
...

[landonf]

• Simplify COMMENT variable definition.

[landonf]

Incorporated latest feedback :-)

[landonf]

Add upstream fix for double-free in blacklist handling.

[landonf]

All requested changes were incorporated, if you wouldn't mind taking another look.

[lwhsu]

The summary says there are 4 master and subports, but the patch seems only adding devel/appmenu-gtk-module?

[landonf]

• Drop the use of FLAVORS -- instead, gtk2/gtk3 are now just config options. FLAVORS are apparently not supported for this type of use in a meta port, and triggered an 'incorrectly depends on itself' error when building with poudriere. See also: https://github.com/freebsd/poudriere/issues/582
• Testing with poudriere also revealed a number of missing dependencies; these have now been added.

[grahamperrin]

https://www.freshports.org/x11/gtk-app-menu/

Port Added: 2020-10-25 10:43:39

The appmenu-gtk-module is …

[arrowd]

Overcome by events: the same software was committed as x11/gtk-app-menu/ port.