Page MenuHomeFreeBSD

[new port] devel/appmenu-gtk-module: GTK+ application menu modules
AbandonedPublic

Authored by arrowd on Jun 11 2019, 3:10 AM.

Details

Reviewers
mat
landonf
Group Reviewers
Contributor Reviewers (ports)
Summary

Integrates applications using the older GtkMenuShell and GtkMenuItem APIs with the desktop environment's global menu bar.

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24861
Build 23607: arc lint + arc unit

Event Timeline

mat requested changes to this revision.Jun 11 2019, 11:24 AM
mat added a subscriber: mat.

Please use flavors.

This revision now requires changes to proceed.Jun 11 2019, 11:24 AM

Adopt FLAVORS, replacing the use of slave ports.

Additionally, fixed two small issues:

  • Add WWW line to pkg-descr
  • Include missing --no-same-(owner|permissions) in EXTRACT_AFTER_ARGS.
devel/appmenu-gtk-module/Makefile
7

Please use flavor helpers.

21

This should be in the .if below.

32

After this line, you do not need to do ${FLAVOR:U}, using ${FLAVOR} is enough.

53

Please use flavor helpers.

Incorporate review feedback:

  • Use flavor helpers
  • Do not specify LICENSE for the meta port
  • Drop use of :U where unnecessary.
devel/appmenu-gtk-module/Makefile
10–18

Please symplify this, no need for all those if's, soemthing like:

COMMENT=  ${COMMENT_${FLAVOR}}
COMMENT_meta=  GTK+ modules to display old-style menus in the global menu bar
COMMENT_common= ...
...
  • Simplify COMMENT variable definition.

Incorporated latest feedback :-)

Add upstream fix for double-free in blacklist handling.

All requested changes were incorporated, if you wouldn't mind taking another look.

The summary says there are 4 master and subports, but the patch seems only adding devel/appmenu-gtk-module?

  • Drop the use of FLAVORS -- instead, gtk2/gtk3 are now just config options. FLAVORS are apparently not supported for this type of use in a meta port, and triggered an 'incorrectly depends on itself' error when building with poudriere. See also: https://github.com/freebsd/poudriere/issues/582
  • Testing with poudriere also revealed a number of missing dependencies; these have now been added.
landonf retitled this revision from [new port] devel/appmenu-gtk-module: GTK+ application menu module to [new port] devel/appmenu-gtk-module: GTK+ application menu modules.
landonf edited the summary of this revision. (Show Details)

https://www.freshports.org/x11/gtk-app-menu/

Port Added: 2020-10-25 10:43:39

The appmenu-gtk-module is …

arrowd abandoned this revision.
arrowd added a reviewer: landonf.

Overcome by events: the same software was committed as x11/gtk-app-menu/ port.