Differential D20592

improve error checking for modifcations to mmap len parameter
ClosedPublic
Actions

Authored by dougm on Jun 10 2019, 7:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 30, 6:45 PM

	Unknown Object (File)
	Sat, Nov 16, 6:47 PM

	Unknown Object (File)
	Thu, Nov 7, 4:15 PM

	Unknown Object (File)
	Oct 3 2024, 10:55 PM

	Unknown Object (File)
	Oct 2 2024, 7:23 AM

	Unknown Object (File)
	Sep 23 2024, 12:14 AM

	Unknown Object (File)
	Sep 21 2024, 4:19 PM

	Unknown Object (File)
	Sep 13 2024, 5:54 AM

View All 39 Files

Subscribers

Details

Reviewers

kib
markj

Commits

rS348879: Change the check for 'size' wrapping around to zero in kern_mmap to account

Summary

Change the check for 'size' wrapping around to zero in kern_mmap to account for both the lower and upper bound modifications. Change the error returned to ENOMEM. Rename the parameter size to len and make size a local variable that stores the value of len after it has been modified.

This addresses concerns expressed by Bruce Evans after r348843.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dougm created this revision.Jun 10 2019, 7:31 PM

kib accepted this revision.Jun 10 2019, 7:57 PM

This revision is now accepted and ready to land.Jun 10 2019, 7:57 PM

markj accepted this revision.Jun 10 2019, 9:17 PM

Closed by commit rS348879: Change the check for 'size' wrapping around to zero in kern_mmap to account (authored by dougm). · Explain WhyJun 10 2019, 9:26 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJun 10 2019, 9:26 PM

I do not seem to be able to boot successfully with this patch?

alc added a subscriber: alc.Jun 10 2019, 9:59 PM

alc added inline comments.

head/sys/vm/vm_mmap.c
262 ↗	(On Diff #58493)	Shouldn't this be (size < len)?

dougm added inline comments.Jun 10 2019, 10:01 PM

head/sys/vm/vm_mmap.c
262 ↗	(On Diff #58493)	Yes, it should.

Revision Contents
Changeset List

Path

Size

sys/

2 lines

vm/

18 lines

Diff 58486

sys/syscallsubr.h

Loading...

vm/vm_mmap.c

Loading...