Differential D20592

improve error checking for modifcations to mmap len parameter
ClosedPublic
Actions

Authored by dougm on Jun 10 2019, 7:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 3, 12:02 AM

	Unknown Object (File)
	Thu, Oct 30, 3:38 PM

	Unknown Object (File)
	Thu, Oct 30, 3:38 PM

	Unknown Object (File)
	Thu, Oct 30, 3:38 PM

	Unknown Object (File)
	Thu, Oct 30, 10:19 AM

	Unknown Object (File)
	Wed, Oct 29, 11:04 AM

	Unknown Object (File)
	Mon, Oct 27, 7:21 AM

	Unknown Object (File)
	Sat, Oct 25, 2:22 AM

View All 89 Files

Subscribers

Details

Reviewers

kib
markj

Commits

rS348879: Change the check for 'size' wrapping around to zero in kern_mmap to account

Summary

Change the check for 'size' wrapping around to zero in kern_mmap to account for both the lower and upper bound modifications. Change the error returned to ENOMEM. Rename the parameter size to len and make size a local variable that stores the value of len after it has been modified.

This addresses concerns expressed by Bruce Evans after r348843.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm created this revision.Jun 10 2019, 7:31 PM

kib accepted this revision.Jun 10 2019, 7:57 PM

This revision is now accepted and ready to land.Jun 10 2019, 7:57 PM

markj accepted this revision.Jun 10 2019, 9:17 PM

Closed by commit rS348879: Change the check for 'size' wrapping around to zero in kern_mmap to account (authored by dougm). · Explain WhyJun 10 2019, 9:26 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJun 10 2019, 9:26 PM

I do not seem to be able to boot successfully with this patch?

alc added a subscriber: alc.Jun 10 2019, 9:59 PM

alc added inline comments.

head/sys/vm/vm_mmap.c
262	Shouldn't this be (size < len)?

dougm added inline comments.Jun 10 2019, 10:01 PM

head/sys/vm/vm_mmap.c
262	Yes, it should.

Revision Contents
Changeset List

Path

Size

head/

sys/

sys/

2 lines

vm/

18 lines

Diff 58493

head/sys/sys/syscallsubr.h

Loading...

head/sys/vm/vm_mmap.c

Loading...