Page MenuHomeFreeBSD
Differential D20516

readelf: decode NT_GNU_PROPERTY_TYPE_0 / GNU_PROPERTY_X86_FEATURE_1_AND
ClosedPublic
Actions

Authored by emaste on Jun 4 2019, 3:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 2, 12:21 AM
Unknown Object (File)
Fri, Nov 28, 2:36 AM
Unknown Object (File)
Wed, Nov 26, 9:31 PM
Unknown Object (File)
Fri, Nov 21, 8:47 PM
Unknown Object (File)
Thu, Nov 20, 7:21 PM
Unknown Object (File)
Thu, Nov 20, 7:15 PM
Unknown Object (File)
Thu, Nov 20, 7:13 PM
Unknown Object (File)
Thu, Nov 20, 7:13 PM
View All Files
Subscribers
imp
kib

Details

Reviewers
markj
csjp
Commits
rS350511: readelf: decode NT_GNU_PROPERTY_TYPE_0 / GNU_PROPERTY_X86_FEATURE_1_AND
Summary

These bits are used for Intel CET IBT/Shadow Stack.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.Jun 4 2019, 3:37 PM
emaste added a parent revision: D20515: elf_common: add GNU note types and NT_GNU_PROPERTY_TYPE_0 bits.
markj added inline comments.Jun 4 2019, 3:50 PM
contrib/elftoolchain/readelf/readelf.c
3437

Redundant parens around buf.

3438

Missing space after =.

3454

"features"?

3459

Misindented break.

emaste updated this revision to Diff 58233.Jun 4 2019, 3:57 PM

Address issues reported by markj

emaste added a subscriber: kib.Aug 1 2019, 5:59 PM
emaste added inline comments.
contrib/elftoolchain/readelf/readelf.c
3454

I used 'feature' for bug compatibility with GNU readelf, but we're going to have minor formatting differences anyway so will go with features.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2019, 6:00 PM
Closed by commit rS350511: readelf: decode NT_GNU_PROPERTY_TYPE_0 / GNU_PROPERTY_X86_FEATURE_1_AND (authored by emaste). · Explain Why
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rS350511: readelf: decode NT_GNU_PROPERTY_TYPE_0 / GNU_PROPERTY_X86_FEATURE_1_AND.
Herald added a subscriber: imp. · View Herald TranscriptAug 1 2019, 6:00 PM
dim mentioned this in rS367462: Sync up elftoolchain with head, except for the capsicum-related commits,.Nov 7 2020, 7:55 PM
dim mentioned this in rS367466: Sync up elftoolchain with head, except for the capsicum-related commits,.Nov 7 2020, 11:58 PM

Revision Contents
Changeset List

PathSize
contrib/
elftoolchain/
readelf/
73 lines

Diff 58230

View Options

contrib/elftoolchain/readelf/readelf.c

Loading...