Paths

Table of Contentst

Differential D20516

readelf: decode NT_GNU_PROPERTY_TYPE_0 / GNU_PROPERTY_X86_FEATURE_1_AND
ClosedPublic
Actions

Authored by emaste on Jun 4 2019, 3:37 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 6, 4:18 PM

	Unknown Object (File)
	Thu, Oct 23, 3:09 PM

	Unknown Object (File)
	Sep 30 2025, 1:04 PM

	Unknown Object (File)
	Sep 28 2025, 9:35 AM

	Unknown Object (File)
	Sep 28 2025, 9:28 AM

	Unknown Object (File)
	Sep 28 2025, 9:27 AM

	Unknown Object (File)
	Sep 28 2025, 9:25 AM

	Unknown Object (File)
	Sep 28 2025, 9:21 AM

Subscribers

Details

Reviewers

markj
csjp

Commits

rS350511: readelf: decode NT_GNU_PROPERTY_TYPE_0 / GNU_PROPERTY_X86_FEATURE_1_AND

Summary

These bits are used for Intel CET IBT/Shadow Stack.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste created this revision.Jun 4 2019, 3:37 PM

emaste added a parent revision: D20515: elf_common: add GNU note types and NT_GNU_PROPERTY_TYPE_0 bits.

markj added inline comments.Jun 4 2019, 3:50 PM

contrib/elftoolchain/readelf/readelf.c
3437 ↗	(On Diff #58230)	Redundant parens around `buf`.
3438 ↗	(On Diff #58230)	Missing space after `=`.
3454 ↗	(On Diff #58230)	"features"?
3459 ↗	(On Diff #58230)	Misindented `break`.

Address issues reported by markj

emaste added a subscriber: kib.Aug 1 2019, 5:59 PM

emaste added inline comments.

contrib/elftoolchain/readelf/readelf.c
3454 ↗	(On Diff #58230)	I used 'feature' for bug compatibility with GNU readelf, but we're going to have minor formatting differences anyway so will go with features.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2019, 6:00 PM

Closed by commit rS350511: readelf: decode NT_GNU_PROPERTY_TYPE_0 / GNU_PROPERTY_X86_FEATURE_1_AND (authored by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rS350511: readelf: decode NT_GNU_PROPERTY_TYPE_0 / GNU_PROPERTY_X86_FEATURE_1_AND.

Herald added a subscriber: imp. · View Herald TranscriptAug 1 2019, 6:00 PM

dim mentioned this in rS367462: Sync up elftoolchain with head, except for the capsicum-related commits,.Nov 7 2020, 7:55 PM

dim mentioned this in rS367466: Sync up elftoolchain with head, except for the capsicum-related commits,.Nov 7 2020, 11:58 PM

Revision Contents
Changeset List

Path

Size

head/

contrib/

elftoolchain/

readelf/

73 lines

Diff 60361

head/contrib/elftoolchain/readelf/readelf.c

Loading...