Page MenuHomeFreeBSD

readelf: decode NT_GNU_PROPERTY_TYPE_0 / GNU_PROPERTY_X86_FEATURE_1_AND
ClosedPublic

Authored by emaste on Jun 4 2019, 3:37 PM.

Details

Summary

These bits are used for Intel CET IBT/Shadow Stack.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj added inline comments.Jun 4 2019, 3:50 PM
contrib/elftoolchain/readelf/readelf.c
3437 ↗(On Diff #58230)

Redundant parens around buf.

3438 ↗(On Diff #58230)

Missing space after =.

3454 ↗(On Diff #58230)

"features"?

3459 ↗(On Diff #58230)

Misindented break.

emaste updated this revision to Diff 58233.Jun 4 2019, 3:57 PM

Address issues reported by markj

emaste added a subscriber: kib.Aug 1 2019, 5:59 PM
emaste added inline comments.
contrib/elftoolchain/readelf/readelf.c
3454 ↗(On Diff #58230)

I used 'feature' for bug compatibility with GNU readelf, but we're going to have minor formatting differences anyway so will go with features.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2019, 6:00 PM
This revision was automatically updated to reflect the committed changes.