Page MenuHomeFreeBSD

Since a fatal trap can happen at aribtrary times, don't panic when the completions are not in a consistent state.
ClosedPublic

Authored by imp on May 30 2019, 9:32 PM.
Tags
None
Referenced Files
F108124445: D20478.diff
Tue, Jan 21, 3:43 PM
Unknown Object (File)
Fri, Jan 17, 3:24 PM
Unknown Object (File)
Sat, Jan 11, 4:43 PM
Unknown Object (File)
Mon, Jan 6, 6:09 PM
Unknown Object (File)
Thu, Jan 2, 4:38 AM
Unknown Object (File)
Dec 1 2024, 5:39 AM
Unknown Object (File)
Nov 20 2024, 11:43 PM
Unknown Object (File)
Nov 6 2024, 1:53 PM
Subscribers

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24612
Build 23395: arc lint + arc unit

Event Timeline

jhb added a subscriber: jhb.

Just a few spelling nits: s/aribtrary/arbitrary/ in log, s/panicing/panicking/ (yes, it looks weird to me too, but adding the 'k' appears to be correct for adding -ing or -ed), s/sceduler/scheduler/, s/leading/leaving/. I still do double spaces at start of sentences in monospace fonts as well FWIW (and style(9) probably wants a blank line before the block comment).

I think your change probably makes sense though. We do similar hacks for lock assertions for similar reasons IIRC.

This revision is now accepted and ready to land.May 31 2019, 12:11 AM
markj added inline comments.
sys/dev/nvme/nvme_qpair.c
526

While here the \n can be removed from the kassert string.

sys/dev/nvme/nvme_qpair.c
526

gotcha

Try a little harder, add comments.

This revision now requires review to proceed.May 31 2019, 3:27 PM

Plug more holes with tips from kib, jhb and markj.

Remove now-obsolete comment.

imp marked an inline comment as done.May 31 2019, 9:06 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 1 2019, 3:37 PM
This revision was automatically updated to reflect the committed changes.