Page MenuHomeFreeBSD
Differential D20478

Since a fatal trap can happen at aribtrary times, don't panic when the completions are not in a consistent state.
ClosedPublic
Actions

Authored by imp on May 30 2019, 9:32 PM.
Tags
None
Referenced Files
F132470957: D20478.id58131.diff
Fri, Oct 17, 5:12 AM
F132470954: D20478.id58124.diff
Fri, Oct 17, 5:12 AM
F132470946: D20478.id58113.diff
Fri, Oct 17, 5:12 AM
F132470940: D20478.id58148.diff
Fri, Oct 17, 5:12 AM
F132470938: D20478.id58132.diff
Fri, Oct 17, 5:12 AM
F132424052: D20478.diff
Thu, Oct 16, 7:52 PM
Unknown Object (File)
Wed, Oct 1, 11:07 AM
Unknown Object (File)
Tue, Sep 30, 10:48 AM
View All Files
Subscribers
jhb

Details

Reviewers
mav
chuck
jimharris
markj
jhb
Commits
rS348495: Since a fatal trap can happen at aribtrary times, don't panic when the

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.May 30 2019, 9:32 PM
Harbormaster completed remote builds in B24612: Diff 58096.May 30 2019, 9:32 PM
imp added reviewers: mav, chuck, jimharris, markj.May 30 2019, 9:34 PM
jhb accepted this revision.May 31 2019, 12:11 AM
jhb added a subscriber: jhb.

Just a few spelling nits: s/aribtrary/arbitrary/ in log, s/panicing/panicking/ (yes, it looks weird to me too, but adding the 'k' appears to be correct for adding -ing or -ed), s/sceduler/scheduler/, s/leading/leaving/. I still do double spaces at start of sentences in monospace fonts as well FWIW (and style(9) probably wants a blank line before the block comment).

I think your change probably makes sense though. We do similar hacks for lock assertions for similar reasons IIRC.

This revision is now accepted and ready to land.May 31 2019, 12:11 AM
markj accepted this revision.May 31 2019, 5:06 AM
markj added inline comments.
sys/dev/nvme/nvme_qpair.c
526 ↗(On Diff #58096)

While here the \n can be removed from the kassert string.

imp added inline comments.May 31 2019, 3:12 PM
sys/dev/nvme/nvme_qpair.c
526 ↗(On Diff #58096)

gotcha

imp updated this revision to Diff 58113.May 31 2019, 3:27 PM

Try a little harder, add comments.

This revision now requires review to proceed.May 31 2019, 3:27 PM
Harbormaster completed remote builds in B24622: Diff 58113.May 31 2019, 3:27 PM
imp updated this revision to Diff 58124.May 31 2019, 8:12 PM

Plug more holes with tips from kib, jhb and markj.

Harbormaster completed remote builds in B24631: Diff 58124.May 31 2019, 8:12 PM
imp updated this revision to Diff 58131.May 31 2019, 9:05 PM

Remove now-obsolete comment.

Harbormaster completed remote builds in B24636: Diff 58131.May 31 2019, 9:05 PM
imp marked an inline comment as done.May 31 2019, 9:06 PM
imp updated this revision to Diff 58132.May 31 2019, 9:10 PM

better comment.

Harbormaster completed remote builds in B24637: Diff 58132.May 31 2019, 9:10 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 1 2019, 3:37 PM
Closed by commit rS348495: Since a fatal trap can happen at aribtrary times, don't panic when the (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
nvme/
79 lines

Diff 58148

View Options

head/sys/dev/nvme/nvme_qpair.c

Loading...