Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Just a few spelling nits: s/aribtrary/arbitrary/ in log, s/panicing/panicking/ (yes, it looks weird to me too, but adding the 'k' appears to be correct for adding -ing or -ed), s/sceduler/scheduler/, s/leading/leaving/. I still do double spaces at start of sentences in monospace fonts as well FWIW (and style(9) probably wants a blank line before the block comment).
I think your change probably makes sense though. We do similar hacks for lock assertions for similar reasons IIRC.
sys/dev/nvme/nvme_qpair.c | ||
---|---|---|
526 โ | (On Diff #58096) | While here the \n can be removed from the kassert string. |
sys/dev/nvme/nvme_qpair.c | ||
---|---|---|
526 โ | (On Diff #58096) | gotcha |