Page MenuHomeFreeBSD

Use vm_page_unwire_noq() instead of vm_page_unwire(PQ_NONE).
ClosedPublic

Authored by markj on May 30 2019, 4:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 22 2024, 2:37 AM
Unknown Object (File)
Jan 25 2024, 7:31 PM
Unknown Object (File)
Jan 25 2024, 7:31 PM
Unknown Object (File)
Jan 25 2024, 7:31 PM
Unknown Object (File)
Jan 25 2024, 1:36 PM
Unknown Object (File)
Dec 20 2023, 4:14 AM
Unknown Object (File)
Nov 11 2023, 5:45 PM
Unknown Object (File)
Nov 9 2023, 8:12 AM
Subscribers

Details

Summary

For managed pages, these two calls are not equivalent:
vm_page_unwire(PQ_NONE) will remove the page from its page queue, if
any, while vm_page_unwire_noq() leaves it alone. However, the existing
callers of vm_page_unwire(PQ_NONE) are applying it to fictitious or
unmanaged pages, so there should be no functional impact.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib added inline comments.
sys/vm/vm_glue.c
233 ↗(On Diff #58077)

Just a note that the page is managed. It is because it is freed immediately after, we can use vm_page_unwire_noq().

This revision is now accepted and ready to land.May 30 2019, 5:27 PM
sys/vm/vm_glue.c
233 ↗(On Diff #58077)

This call was added in D19247, so it will not be committed with the rest of this diff.

This revision was automatically updated to reflect the committed changes.