Page MenuHomeFreeBSD
Differential D20470

Use vm_page_unwire_noq() instead of vm_page_unwire(PQ_NONE).
ClosedPublic
Actions

Authored by markj on May 30 2019, 4:36 PM.
Tags
None
Referenced Files
F136154836: D20470.id.diff
Sun, Nov 16, 6:18 AM
F136153557: D20470.id59490.diff
Sun, Nov 16, 5:59 AM
F136139081: D20470.id58077.diff
Sun, Nov 16, 2:42 AM
F136135068: D20470.id59490.diff
Sun, Nov 16, 1:49 AM
Unknown Object (File)
Tue, Oct 28, 3:46 AM
Unknown Object (File)
Sat, Oct 18, 10:58 PM
Unknown Object (File)
Sat, Oct 18, 10:18 PM
Unknown Object (File)
Oct 11 2025, 8:18 AM
View All Files
Subscribers
andrew
emaste
imp

Details

Reviewers
alc
kib
dougm
Commits
rS348785: Replace uses of vm_page_unwire(m, PQ_NONE) with vm_page_unwire_noq(m).
Summary

For managed pages, these two calls are not equivalent:
vm_page_unwire(PQ_NONE) will remove the page from its page queue, if
any, while vm_page_unwire_noq() leaves it alone. However, the existing
callers of vm_page_unwire(PQ_NONE) are applying it to fictitious or
unmanaged pages, so there should be no functional impact.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.May 30 2019, 4:36 PM
Herald added subscribers: emaste, andrew. · View Herald TranscriptMay 30 2019, 4:36 PM
Harbormaster completed remote builds in B24602: Diff 58077.May 30 2019, 4:37 PM
markj added reviewers: alc, kib, dougm.May 30 2019, 4:37 PM
kib accepted this revision.May 30 2019, 5:27 PM
kib added inline comments.
sys/vm/vm_glue.c
233 ↗(On Diff #58077)

Just a note that the page is managed. It is because it is freed immediately after, we can use vm_page_unwire_noq().

This revision is now accepted and ready to land.May 30 2019, 5:27 PM
markj added inline comments.Jun 7 2019, 6:12 PM
sys/vm/vm_glue.c
233 ↗(On Diff #58077)

This call was added in D19247, so it will not be committed with the rest of this diff.

Closed by commit rS348785: Replace uses of vm_page_unwire(m, PQ_NONE) with vm_page_unwire_noq(m). (authored by markj). · Explain WhyJul 7 2019, 4:44 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptJul 7 2019, 4:44 AM

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
amd64/
2 lines
arm/
arm/
2 lines
nvidia/
drm2/
2 lines
compat/
linuxkpi/
common/
src/
2 lines
dev/
drm2/
ttm/
2 lines
ti/
2 lines
xen/
gntdev/
2 lines
i386/
i386/
2 lines
mips/
mips/
2 lines
riscv/
riscv/
2 lines
vm/
8 lines
2 lines
2 lines

Diff 59490

View Options

head/sys/amd64/amd64/pmap.c

Loading...
View Options

head/sys/arm/arm/pmap-v6.c

Loading...
View Options

head/sys/arm/nvidia/drm2/tegra_bo.c

Loading...
View Options

head/sys/compat/linuxkpi/common/src/linux_page.c

Loading...
View Options

head/sys/dev/drm2/ttm/ttm_page_alloc.c

Loading...
View Options

head/sys/dev/ti/if_ti.c

Loading...
View Options

head/sys/dev/xen/gntdev/gntdev.c

Loading...
View Options

head/sys/i386/i386/pmap.c

Loading...
View Options

head/sys/mips/mips/pmap.c

Loading...
View Options

head/sys/riscv/riscv/pmap.c

Loading...
View Options

head/sys/vm/uma_core.c

Loading...
View Options

head/sys/vm/vm_glue.c

Loading...
View Options

head/sys/vm/vm_kern.c

Loading...