Page MenuHomeFreeBSD

Make linux(4) create /dev/shm.
AcceptedPublic

Authored by trasz on May 21 2019, 12:29 PM.

Details

Reviewers
tijl
dchagin
Summary

Make linux(4) create /dev/shm. Linux applications often expect
a tmpfs to be mounted there, and because they like to verify it's
actually a mountpoint, a symlink won't do.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 24421
Build 23235: arc lint + arc unit

Event Timeline

trasz created this revision.May 21 2019, 12:29 PM

linux_common is not used in i386

I would prefer put common code to the compat/linux/linux.c and put linux_dev_shm_destroy/linux_dev_shm_create decl to the linux.h

trasz updated this revision to Diff 57633.May 21 2019, 3:11 PM

Move stuff around.

trasz added a comment.May 21 2019, 3:12 PM

linux_common is not used in i386

What do you mean? Or, ask another way, where should I call it from to make it work for i386?

linux_common is not used in i386

What do you mean? Or, ask another way, where should I call it from to make it work for i386?

in linux_elf_modevent() in i386/linux/linux_sysvec.c

trasz updated this revision to Diff 57758.May 23 2019, 12:22 PM

Also call stuff for i386.

dchagin accepted this revision.May 23 2019, 6:55 PM
This revision is now accepted and ready to land.May 23 2019, 6:55 PM
tijl added a comment.May 24 2019, 8:21 AM

Please also bump OSVERSION so the creation of /compat/linux/dev/shm can be made conditional in emulators/linux_base-c[67]

as far as I understand we can create /dev/fd same way?

trasz added a comment.May 25 2019, 7:40 PM

This is a bit hacky, even for my standards, so I've come up with this as an alternative: https://reviews.freebsd.org/D20411.