Page MenuHomeFreeBSD

Eliminate duplicate `afterinstallconfigs` target
ClosedPublic

Authored by ngie on May 21 2019, 4:52 AM.
Tags
None
Referenced Files
F106055370: D20330.diff
Tue, Dec 24, 3:11 PM
Unknown Object (File)
Fri, Dec 20, 7:09 PM
Unknown Object (File)
Nov 5 2024, 6:36 AM
Unknown Object (File)
Oct 24 2024, 9:20 PM
Unknown Object (File)
Oct 4 2024, 10:02 PM
Unknown Object (File)
Oct 4 2024, 9:26 AM
Unknown Object (File)
Oct 4 2024, 6:30 AM
Unknown Object (File)
Oct 1 2024, 11:04 PM

Details

Summary

Define separate dependent targets which afterinstallconfigs relies on, in
order to modify ${DESTDIR}/etc/master.passwd and
${DESTDIR}/etc/nsswitch.conf.

Mark these targets .PHONY, since they manipulate configurations on the fly and
the generation logic isn't 100% defined in terms of the source files/logic,
and is variable, based on MK_foo flags.

Test Plan

Before:

$ (cd lib/libc; make buildenv)
[Creating objdir /usr/obj/home/ngie/svn/freebsd/base/projects/runtime-coverage-v2/amd64.amd64/lib/libc...]
make: "/home/ngie/svn/freebsd/base/projects/runtime-coverage-v2/lib/libc/net/Makefile.inc" line 130: warning: duplicate script for target "afterinstallconfig" ignored
make: "/home/ngie/svn/freebsd/base/projects/runtime-coverage-v2/lib/libc/gen/Makefile.inc" line 552: warning: using previous script for "afterinstallconfig" defined here
$

After:

$ (cd lib/libc; make buildenv)
Entering world for amd64:amd64
$

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Still an issue:

$ (cd ~/svn/freebsd/base/head/; svnversion; make -C lib/libc buildenv)
352519
make: "/home/ngie/svn/freebsd/base/head/lib/libc/net/Makefile.inc" line 130: warning: duplicate script for target "afterinstallconfig" ignored
make: "/home/ngie/svn/freebsd/base/head/lib/libc/gen/Makefile.inc" line 554: warning: using previous script for "afterinstallconfig" defined here
Entering world for amd64:amd64

Thanks, sorry I missed the notification about this review before.

This revision is now accepted and ready to land.Sep 19 2019, 6:55 PM
This revision was automatically updated to reflect the committed changes.